Add waitForCache option for waiting caching before returning the retrieved image
#963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! Seems cool. I will look at it this weekend. :] |
|
Hey @onevcat. 👋 Did you get a chance to look at this? Let me know if I can help. |
|
LGTM! Sorry for the latency! |
petarlazarov
pushed a commit
to dowjones-mobile/Kingfisher
that referenced
this pull request
Oct 6, 2021
Add `waitForCache` option for waiting caching before returning the retrieved image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After downloading an image, we sometimes need to wait for caching to be completed so that we can copy the file or use the cache path for some other operations. This
waitForCacheoption allows us to achieve that behavior.Fixes #956