Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/selenium js set up #620

Merged
merged 44 commits into from
May 1, 2019
Merged

Improvement/selenium js set up #620

merged 44 commits into from
May 1, 2019

Conversation

rfreitas
Copy link
Contributor

@rfreitas rfreitas commented Apr 15, 2019 •
edited
Loading

Problem

The ruby test stack (after much trying) does not allow us to upload file to IE11 on browserstack.
Also it's a very inflexible stack, since it's based on a library which was designed for particular cases (monster)

Solution

Create a new stack based in JS (since it's the main language of the project), that allow us to define tests and the browsers (local or remote) that will run those tests.

The approach was also to start small for now (only one test case with file upload)

Technical considerations

  1. webdriverio was tried, but it didn't work with file upload. They have removed support from in the latest versions.
  2. Selenium (js) webdriver was picked instead. It works well. It's fully async though, which makes code a bit more complicated
    2.1. Babel auto await was added to simplify the test case code
  3. Mocha was added due to good community support. However some changes were done to reduce the need for globals. Namely the name main mocha functions were wrapped to allow for the non global passing of the driver and also the initialization of page objects
  4. The ruby test execution was brought into the js scripts, so that parallelization can happen and so can does the sharing of the http server.

Checklist

put n/a if item is not relevant to PR changes

  • Have the CHANGELOG, README, MIGRATION, RELEASE_GUIDELINES docs been updated?
  • Have new automated tests been implemented?
  • Have new manual tests been written down?
  • Have tests passed locally?
  • Have any new strings been translated?

rfreitas added 25 commits April 6, 2019 00:34
@rfreitas
Hello world test with selenium JS
285c741
@rfreitas
file upload working
764abf2
@rfreitas
File upload working on IE11
af61a09
@rfreitas
added a mocha runner; runs on chrome and IE in browserstack
c510739
@rfreitas
Created lint rules for ui tests
469de38
@rfreitas
moved driver creation to its own function; passed driver to context (…
8c7c6eb 
…no global)
@rfreitas
Made browsers parallel
064d538
@rfreitas
created independent browerstack local for each browser
8e5c127
@rfreitas
Owner of driver terminates it and browserstack local
356e450
@rfreitas
Fixed bug where driver was call on every failure
c0d1e83
@rfreitas
improved mocha async wrapper to handle unhandled promise rejections
c1dec89
@rfreitas
More promise error handling
9473057
@rfreitas
wraped mocha with more convenient functions
ad462cb
@rfreitas
refactoring to page object pattern
49c8c5e
@rfreitas
Refactor to move some stuff to utils
568021f
@rfreitas
added support for local browsers
f9f36b7
@rfreitas
Fixed linter for src
5ff10b4
@rfreitas
reorganized config data to be test with browsers
d034bb9
@rfreitas
Formatted spacing
ea5b3bd
@rfreitas
refactor to reduce some boilerplate around page objections creation
d3394db
@rfreitas
Started server for js ui test
032b257
@rfreitas
made js ui test start http server
58bd660 
Fixed eachP which wasn’t working
@rfreitas
Better promise handling for killing of server
6cdc36d
@rfreitas
Merge branch 'development' into improvement/selenium-js-set-up
e8d7fe2 
# Conflicts:
#	package-lock.json
#	package.json
@rfreitas
made js tests exit with error code if any fail
6c4709b
@rfreitas rfreitas changed the base branch from master to development April 15, 2019 11:40
@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://release-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://release-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://release-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://release-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
PR feedback: created constant for color, added space; renamed method
9bb9fe3 
Consistent indentation in util file
Renamed copy to string for more familiar international speakers
@rfreitas rfreitas force-pushed the improvement/selenium-js-set-up branch from 1b4afef to 9bb9fe3 Compare April 30, 2019 09:21
@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://release-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://release-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://release-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://staging-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://release-620-pr-onfido-sdk-ui-onfido.surge.sh

@rfreitas
Copy link
Contributor Author

Travis automatic deployment: https://620-pr-onfido-sdk-ui-onfido.surge.sh

stefaniacardenas
stefaniacardenas approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@stefaniacardenas stefaniacardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we need to add an internal note in the changelog?

@rfreitas
Copy link
Contributor Author

I don't think so. it's not in the sdk codebase.

@bartzet bartzet merged commit 4c73c7f into development May 1, 2019
@josokinas josokinas deleted the improvement/selenium-js-set-up branch July 10, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josokinas josokinas josokinas approved these changes

@joninvski joninvski joninvski left review comments

@bartzet bartzet bartzet approved these changes

@stefaniacardenas stefaniacardenas stefaniacardenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rfreitas @bartzet @joninvski @stefaniacardenas @josokinas