Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for changing type info of atree arrays (atree inlining branch) #376

Merged

Conversation

fxamacker
Copy link
Member

@fxamacker fxamacker commented Mar 5, 2024

Updates #372

This feature is needed by Cadence migrations to update static types. For more details, see

This PR adds Array.SetType() to allow updating TypeInfo.

NOTE: Implementation of this in atree inlining branch is different than non-inlining branch(es).


  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker added enhancement New feature or request E&V Team Execution / Verification / Edge Team labels Mar 5, 2024
@fxamacker fxamacker self-assigned this Mar 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 58.64198% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 63.22%. Comparing base (2fbf860) to head (8c7c31e).

Files Patch % Lines
array.go 62.96% 30 Missing ⚠️
map.go 55.22% 30 Missing ⚠️
storage.go 50.00% 3 Missing and 1 partial ⚠️
storable_slab.go 0.00% 2 Missing ⚠️
basicarray.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feature/array-map-inlining     #376      +/-   ##
==============================================================
+ Coverage                       62.45%   63.22%   +0.76%     
==============================================================
  Files                              15       15              
  Lines                           10919    10791     -128     
==============================================================
+ Hits                             6820     6823       +3     
+ Misses                           3119     3005     -114     
+ Partials                          980      963      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for adding this!

Same feedback as for the related PR, the non-register inlining, #374

array.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E&V Team Execution / Verification / Edge Team enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants