Fix move of resource dictionary value #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kay-Zee
approved these changes
May 23, 2020
| // so must be written (potentially as a deferred value again), | ||
| // and would otherwise be ignored by the writeback optimization. | ||
|
|
||
| value.SetModified(true) |
Base automatically changed from
bastian/fix-resource-dictionary-value-deferral-destruction
to
master
May 24, 2020 00:52
turbolent
force-pushed
the
bastian/fix-resource-dictionary-value-deferral
branch
from
3fe40e2 to
64dd3d9
Compare
SupunS
pushed a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already handled the move/transfer of dictionaries with deferred values by moving the the deferred storage keys.
However, we also have to handle the move/transfer of a dictionary value from one dictionary to another: If the value is not modified, the writeback optimization will ignore the new value in the receiving dictionary, so mark the moved/transferred value as modified.