New Parser: Composite declarations #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
force-pushed
the
bastian/new-parser-composite-declaration
branch
from
92e9ba9 to
60d27e2
Compare
turbolent
force-pushed
the
bastian/new-parser-composite-declaration
branch
from
86c7037 to
61064ed
Compare
benjaminkvm
reviewed
May 26, 2020
| p.skipSpaceAndComments(true) | ||
| // parseNominalTypes parses zero or more nominal types separated by comma. | ||
| // | ||
| func parseNominalTypes( |
There was a problem hiding this comment.
Might be able to use this for type arguments 👍
benjaminkvm
approved these changes
May 26, 2020
SupunS
added a commit
that referenced
this pull request
Jul 11, 2023
[v0.39] Prevent recursive transfers (internal #133)
SupunS
pushed a commit
that referenced
this pull request
Jul 11, 2023
SupunS
added a commit
that referenced
this pull request
Jul 12, 2023
Prevent recursive transfers (internal #133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards dapperlabs/flow-go#3764
Also:
The changes in
parser_test.goare all just indentation changes, plus the end position fixes mentioned above, the diff looks quite weird, maybe best viewed by disabling whitespace in the GitHub diff