Enforce account links to be private

[turbolent]

Work towards #2192

Description

The Account linking FLIP received some great feedback, suggesting that account links should not be public.

Enforce this by changing the type of the path parameter of the linkAccount function from CapabilityPath to PrivatePath.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0f76c23
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
CheckContractInterfaceFungibleTokenConformance-2	118µs ± 0%	131µs ± 0%	~	(p=1.000 n=1+1)
ContractInterfaceFungibleToken-2	38.9µs ± 0%	39.5µs ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-2	502ns ± 0%	352ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-2	57.8ns ± 0%	53.4ns ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-2	2.40ms ± 0%	2.44ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-2	1.13µs ± 0%	1.15µs ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-2	598ns ± 0%	612ns ± 0%	~	(p=1.000 n=1+1)
ParseArray-2	7.95ms ± 0%	8.82ms ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/byte_array-2	12.1ms ± 0%	12.4ms ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/decode_hex-2	1.31ms ± 0%	1.23ms ± 0%	~	(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-2	188µs ± 0%	189µs ± 0%	~	(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-2	151µs ± 0%	150µs ± 0%	~	(p=1.000 n=1+1)
ParseInfix-2	6.98µs ± 0%	7.06µs ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-2	2.34ns ± 0%	2.35ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-2	138ns ± 0%	140ns ± 0%	~	(p=1.000 n=1+1)
RuntimeResourceDictionaryValues-2	5.21ms ± 0%	5.24ms ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-2	3.93µs ± 0%	4.01µs ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/arrays-2	317ns ± 0%	317ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-2	134ns ± 0%	134ns ± 0%	~	(all equal)
SuperTypeInference/integers-2	89.2ns ± 0%	89.2ns ± 0%	~	(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-2	91.5ns ± 0%	92.5ns ± 0%	~	(p=1.000 n=1+1)
	alloc/op		delta
CheckContractInterfaceFungibleTokenConformance-2	48.9kB ± 0%	48.9kB ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	23.2kB ± 0%	23.2kB ± 0%	~	(all equal)
ExportType/composite_type-2	136B ± 0%	136B ± 0%	~	(all equal)
ExportType/simple_type-2	0.00B	0.00B	~	(all equal)
InterpretRecursionFib-2	1.00MB ± 0%	1.00MB ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	768B ± 0%	768B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	200B ± 0%	200B ± 0%	~	(all equal)
ParseArray-2	2.65MB ± 0%	2.73MB ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/byte_array-2	4.09MB ± 0%	4.27MB ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/decode_hex-2	214kB ± 0%	214kB ± 0%	~	(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-2	28.9kB ± 0%	28.9kB ± 0%	~	(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-2	28.9kB ± 0%	28.9kB ± 0%	~	(all equal)
ParseInfix-2	1.91kB ± 0%	1.92kB ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-2	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-2	2.29MB ± 0%	2.28MB ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-2	2.70kB ± 0%	2.70kB ± 0%	~	(all equal)
SuperTypeInference/arrays-2	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-2	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-2	0.00B	0.00B	~	(all equal)
ValueIsSubtypeOfSemaType-2	48.0B ± 0%	48.0B ± 0%	~	(all equal)
	allocs/op		delta
CheckContractInterfaceFungibleTokenConformance-2	806 ± 0%	806 ± 0%	~	(all equal)
ContractInterfaceFungibleToken-2	370 ± 0%	370 ± 0%	~	(all equal)
ExportType/composite_type-2	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-2	0.00	0.00	~	(all equal)
InterpretRecursionFib-2	18.9k ± 0%	18.9k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-2	13.0 ± 0%	13.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-2	4.00 ± 0%	4.00 ± 0%	~	(all equal)
ParseArray-2	59.6k ± 0%	59.6k ± 0%	~	(all equal)
ParseDeploy/byte_array-2	89.4k ± 0%	89.4k ± 0%	~	(all equal)
ParseDeploy/decode_hex-2	63.0 ± 0%	63.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-2	768 ± 0%	768 ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-2	768 ± 0%	768 ± 0%	~	(all equal)
ParseInfix-2	48.0 ± 0%	48.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-2	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-2	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeResourceDictionaryValues-2	36.9k ± 0%	36.9k ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-2	43.0 ± 0%	43.0 ± 0%	~	(all equal)
SuperTypeInference/arrays-2	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-2	0.00	0.00	~	(all equal)
SuperTypeInference/integers-2	0.00	0.00	~	(all equal)
ValueIsSubtypeOfSemaType-2	1.00 ± 0%	1.00 ± 0%	~	(all equal)

[codecov]

Codecov Report

Merging #2366 (1775ebd) into master (b5f57e9) will increase coverage by 0.26%.
The diff coverage is 92.39%.

@@            Coverage Diff             @@
##           master    #2366      +/-   ##
==========================================
+ Coverage   78.23%   78.49%   +0.26%     
==========================================
  Files         312      316       +4     
  Lines       67045    68409    +1364     
==========================================
+ Hits        52452    53697    +1245     
- Misses      12821    12915      +94     
- Partials     1772     1797      +25     

Flag	Coverage Δ
unittests	78.49% <92.39%> (+0.26%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
runtime/common/declarationkind.go	80.46% <63.63%> (-2.04%)	⬇️
runtime/sema/check_pragma.go	94.33% <91.42%> (ø)
runtime/runtime.go	85.16% <100.00%> (ø)
runtime/sema/authaccount_type.go	100.00% <100.00%> (ø)
runtime/sema/checker.go	92.60% <100.00%> (+0.19%)	⬆️
runtime/sema/errors.go	93.08% <100.00%> (+0.24%)	⬆️
runtime/interpreter/errors.go	56.47% <0.00%> (-3.45%)	⬇️
runtime/ast/memberindices.go	93.81% <0.00%> (-2.66%)	⬇️
runtime/ast/expression_extractor.go	46.19% <0.00%> (-2.54%)	⬇️
types.go	82.30% <0.00%> (-2.48%)	⬇️
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.