Bring back type IDs in JSON encoding of function types and restricted types #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsainati1
approved these changes
Jun 8, 2023
SupunS
approved these changes
Jun 8, 2023
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:master commit 37e11a4 Collapsed results for better readability
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Verified the fixes by switching the Emulator to use this PR, and then running scripts that return function types and restricted types: $ flow scripts execute <(echo 'pub fun main(): Type { return Type<((): Void)>() }')
Result: Type<(():Void)>()$ flow scripts execute <(echo 'pub struct S {}; pub fun main(): Type { return Type<S{}>() }')
Result: Type<s.468a847f9bdbfee1049c59934b561d32cba5f3045bf3bf7549653cf77e04e6d5.S{}>()These scripts currently fail with: |
turbolent
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JSON-CDC encoding of restricted types and function types used to have type IDs.
The type IDs got replaced with structured equivalents. For example, function types used to only have a type ID, but now include parameter types, return type, etc.
#2401 removed the redundant type IDs.
However, before the removal, the JSON decoder required these type IDs. The older decoder is still used by developers in older Go SDK and Flow CLI releases.
Bring back the type IDs for backward compatibility.
masterbranchFiles changedin the Github PR explorer