Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for resource tracking in bound function invocations #2570

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jun 13, 2023

Description

Port of #2569

Adding a test case for the fix #2568


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Testing label Jun 13, 2023
@SupunS SupunS self-assigned this Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2570 (7e0d387) into v0.31 (c59a461) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            v0.31    #2570   +/-   ##
=======================================
  Coverage   77.72%   77.72%           
=======================================
  Files         309      309           
  Lines       65861    65861           
=======================================
  Hits        51191    51191           
  Misses      12890    12890           
  Partials     1780     1780           
Flag Coverage Δ
unittests 77.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:v0.31 commit c59a461
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS merged commit 5ab5041 into v0.31 Jun 13, 2023
@SupunS SupunS deleted the supun/v0.31-resource-tracking-tests branch June 13, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants