Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Character.utf8 #2617

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Introduce Character.utf8 #2617

merged 5 commits into from
Jun 29, 2023

Conversation

darkdrag00nv2
Copy link
Contributor

@darkdrag00nv2 darkdrag00nv2 commented Jun 28, 2023 •
edited
Loading

Closes #2604

Description

Introduce Character.utf8 similar to String.utf8.

Docs PR will follow soon.

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

turbolent
turbolent reviewed Jun 28, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

runtime/interpreter/value.go Show resolved Hide resolved
@turbolent turbolent self-assigned this Jun 28, 2023
@turbolent turbolent assigned SupunS and unassigned turbolent Jun 28, 2023
turbolent
turbolent approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

runtime/interpreter/value.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #2617 (7555576) into master (85d72b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2617   +/-   ##
=======================================
  Coverage   78.60%   78.60%           
=======================================
  Files         336      336           
  Lines       77866    77877   +11     
=======================================
+ Hits        61206    61217   +11     
  Misses      14379    14379           
  Partials     2281     2281
Flag Coverage Δ
unittests 78.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
runtime/interpreter/value.go 68.85% <100.00%> (+<0.01%) ⬆️
runtime/sema/character.gen.go 100.00% <100.00%> (ø)

@darkdrag00nv2 @turbolent
Meter before allocation
7555576 
Co-authored-by: Bastian Müller <bastian@turbolent.com>
@turbolent turbolent merged commit 5f84e78 into onflow:master Jun 29, 2023
@darkdrag00nv2 darkdrag00nv2 deleted the charutf8 branch June 29, 2023 17:55
@darkdrag00nv2 darkdrag00nv2 mentioned this pull request Jul 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@dsainati1 dsainati1 dsainati1 approved these changes

@SupunS SupunS Awaiting requested review from SupunS SupunS is a code owner

Assignees

@SupunS SupunS

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Character.utf8 similar to String.utf8 field
4 participants
@darkdrag00nv2 @turbolent @dsainati1 @SupunS