Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Storage.AccountStorageFormat() #3701

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add Storage.AccountStorageFormat() #3701

merged 1 commit into from
Nov 27, 2024
+285 −11

Conversation

fxamacker
Copy link
Member

Updates #3584

This PR exports runtime.StorageFormat and adds Storage.AccountStorageFormat().

Storage.AccountStorageFormat() returns:

  • either StorageFormatV1 or StorageFormatV2 for existing accounts
  • StorageFormatUnknown for non-existing accounts.

Thanks @turbolent for this idea!

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@fxamacker fxamacker self-assigned this Nov 27, 2024
turbolent
turbolent approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@fxamacker fxamacker merged commit 427957d into fxamacker/merge-feature-branch-combine-domain-payloads-to-master-branch Nov 27, 2024
@BrewTestBot BrewTestBot mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

@SupunS SupunS Awaiting requested review from SupunS

Assignees

@fxamacker fxamacker

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fxamacker @turbolent