Remove pub, priv and pub(set) documentation

docs/cadence/anti-patterns.mdx

@@ -31,7 +31,7 @@ which provides the opportunity for bad actors to take advantage of.
 
 // They could deploy the contract with an Ethereum-style access control list functionality
 
-pub fun transferNFT(id: UInt64, owner: AuthAccount) {
+access(all) fun transferNFT(id: UInt64, owner: AuthAccount) {
     assert(owner(id) == owner.address)
 
     transfer(id)
@@ -43,7 +43,7 @@ pub fun transferNFT(id: UInt64, owner: AuthAccount) {
 // should not be accessible in this function
 // BAD
 
-pub fun transferNFT(id: UInt64, owner: AuthAccount) {
+access(all) fun transferNFT(id: UInt64, owner: AuthAccount) {
     assert(owner(id) == owner.address)
 
     transfer(id)
@@ -201,9 +201,9 @@ if these fields are mistakenly made public.
 Ex:
 
 ```cadence
-pub contract Array {
+access(all) contract Array {
     // array is intended to be initialized to something constant
-    pub let shouldBeConstantArray: [Int]
+    access(all) let shouldBeConstantArray: [Int]
 }
 ```
 
@@ -225,7 +225,7 @@ Make sure that any array or dictionary fields in contracts, structs, or resource
 are `access(contract)` or `access(self)` unless they need to be intentionally made public.
 
 ```cadence
-pub contract Array {
+access(all) contract Array {
     // array is inteded to be initialized to something constant
     access(self) let shouldBeConstantArray: [Int]
 }
@@ -252,27 +252,27 @@ The admin resource can then be `link()`ed to a private path in an admin's accoun
 // Pseudo-code
 
 // BAD
-pub contract Currency {
-    pub resource Admin {
-        pub fun mintTokens()
+access(all) contract Currency {
+    access(all) resource Admin {
+        access(all) fun mintTokens()
     }
 
     // Anyone in the network can call this function
     // And use the Admin resource to mint tokens
-    pub fun createAdmin(): @Admin {
+    access(all) fun createAdmin(): @Admin {
         return <-create Admin()
     }
 }
 
 // This contract makes the admin creation private and in the initializer
 // so that only the one who controls the account can mint tokens
 // GOOD
-pub contract Currency {
-    pub resource Admin {
-        pub fun mintTokens()
+access(all) contract Currency {
+    access(all) resource Admin {
+        access(all) fun mintTokens()
 
         // Only an admin can create new Admins
-        pub fun createAdmin(): @Admin {
+        access(all) fun createAdmin(): @Admin {
             return <-create Admin()
         }
     }
@@ -313,14 +313,14 @@ which increments the number that tracks the play IDs and emits an event:
 // Simplified Code
 // BAD
 //
-pub contract TopShot {
+access(all) contract TopShot {
 
     // The Record that is used to track every unique play ID
-    pub var nextPlayID: UInt32
+    access(all) var nextPlayID: UInt32
 
-    pub struct Play {
+    access(all) struct Play {
 
-        pub let playID: UInt32
+        access(all) let playID: UInt32
 
         init() {
 
@@ -348,24 +348,24 @@ that creates the plays.
 // Update contract state in admin resource functions
 // GOOD
 //
-pub contract TopShot {
+access(all) contract TopShot {
 
     // The Record that is used to track every unique play ID
-    pub var nextPlayID: UInt32
+    access(all) var nextPlayID: UInt32
 
-    pub struct Play {
+    access(all) struct Play {
 
-        pub let playID: UInt32
+        access(all) let playID: UInt32
 
         init() {
             self.playID = TopShot.nextPlayID
         }
     }
 
-    pub resource Admin {
+    access(all) resource Admin {
 
         // Protected within the private admin resource
-        pub fun createPlay() {
+        access(all) fun createPlay() {
             // Create the new Play
             var newPlay = Play()
 

docs/cadence/design-patterns.mdx

@@ -29,7 +29,7 @@ See [Wikipedia's page on magic numbers](https://en.wikipedia.org/wiki/Magic_numb
 
 ### Solution
 
-Add a public (`pub`), constant (`let`) field, e.g. a `Path` , to the contract responsible for the value,
+Add a public (`access(all)`), constant (`let`) field, e.g. a `Path` , to the contract responsible for the value,
 and set it in the contract's initializer.
 Refer to that value via this public field rather than specifying it manually.
 
@@ -38,8 +38,8 @@ Example Snippet:
 ```cadence
 
 // BAD Practice: Do not hard code storage paths
-pub contract NamedFields {
-    pub resource Test {}
+access(all) contract NamedFields {
+    access(all) resource Test {}
 
     init() {
         // BAD: Hard-coded storage path
@@ -49,11 +49,11 @@ pub contract NamedFields {
 
 // GOOD practice: Instead, use a field
 //
-pub contract NamedFields {
-    pub resource Test {}
+access(all) contract NamedFields {
+    access(all) resource Test {}
 
     // GOOD: field storage path
-    pub let TestStoragePath: StoragePath
+    access(all) let TestStoragePath: StoragePath
 
     init() {
         // assign and access the field here and in transactions
@@ -81,7 +81,7 @@ Your contract, resource or struct has a field or resource that will need to be r
 Make sure that the field can be accessed from a script (using a `PublicAccount`)
 rather than requiring a transaction (using an `AuthAccount`).
 This saves the time and fees required to read a property using a transaction.
-Making the field or function `pub` and exposing it via a `/public/` capability will allow this.
+Making the field or function `access(all)` and exposing it via a `/public/` capability will allow this.
 
 Be careful not to expose any data or functionality that should be kept private when doing so.
 
@@ -92,7 +92,7 @@ Example:
 access(self) let totalSupply: UFix64
 
 // GOOD: Field is public, so it can be read and used by anyone
-pub let totalSupply: UFix64
+access(all) let totalSupply: UFix64
 ```
 
 ## Script-Accessible report
@@ -118,25 +118,25 @@ See [Script-Accessible public field/function](#script-accessible-public-fieldfun
 ### Example Code
 
 ```cadence
-pub contract AContract {
-    pub let BResourceStoragePath: StoragePath
-    pub let BResourcePublicPath: PublicPath
+access(all) contract AContract {
+    access(all) let BResourceStoragePath: StoragePath
+    access(all) let BResourcePublicPath: PublicPath
 
     init() {
         self.BResourceStoragePath = /storage/BResource
         self.BResourcePublicPath = /public/BResource
     }
 
     // Resource definition
-    pub resource BResource {
-        pub var c: UInt64
-        pub var d: String
+    access(all) resource BResource {
+        access(all) var c: UInt64
+        access(all) var d: String
 
 
         // Generate a struct with the same fields
         // to return when a script wants to see the fields of the resource
         // without having to return the actual resource
-        pub fun generateReport(): BReportStruct {
+        access(all) fun generateReport(): BReportStruct {
             return BReportStruct(c: self.c, d: self.d)
         }
 
@@ -147,9 +147,9 @@ pub contract AContract {
     }
 
     // Define a struct with the same fields as the resource
-    pub struct BReportStruct {
-        pub var c: UInt64
-        pub var d: String
+    access(all) struct BReportStruct {
+        access(all) var c: UInt64
+        access(all) var d: String
 
         init(c: UInt64, d: String) {
             self.c = c
@@ -172,7 +172,7 @@ transaction {
 import AContract from 0xAContract
 
 // Return the struct with a script
-pub fun main(account: Address): AContract.BReportStruct {
+access(all) fun main(account: Address): AContract.BReportStruct {
     // borrow the resource
     let b = getAccount(account)
         .getCapability(AContract.BResourcePublicPath)
@@ -225,12 +225,12 @@ All fields, functions, types, variables, etc., need to have names that clearly d
 ```cadence
 // BAD: Unclear naming
 //
-pub contract Tax {
+access(all) contract Tax {
     // Do not use abbreviations unless absolutely necessary
-    pub var pcnt: UFix64
+    access(all) var pcnt: UFix64
 
     // Not clear what the function is calculating or what the parameter should be
-    pub fun calculate(num: UFix64): UFix64 {
+    access(all) fun calculate(num: UFix64): UFix64 {
         // What total is this referring to?
         let total = num + (num * self.pcnt)
 
@@ -240,13 +240,13 @@ pub contract Tax {
 
 // GOOD: Clear naming
 //
-pub contract TaxUtilities {
+access(all) contract TaxUtilities {
     // Clearly states what the field is for
-    pub var taxPercentage: UFix64
+    access(all) var taxPercentage: UFix64
 
     // Clearly states that this function calculates the
     // total cost after tax
-    pub fun calculateTotalCostPlusTax(preTaxCost: UFix64): UFix64 {
+    access(all) fun calculateTotalCostPlusTax(preTaxCost: UFix64): UFix64 {
         let postTaxCost = preTaxCost + (preTaxCost * self.taxPercentage)
 
         return postTaxCost
@@ -303,7 +303,7 @@ This could be used when purchasing an NFT to verify that the NFT was deposited i
 
 transaction {
 
-    pub let buyerCollectionRef: &NonFungibleToken.Collection
+    access(all) let buyerCollectionRef: &NonFungibleToken.Collection
 
     prepare(acct: AuthAccount) {