Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update account linking docs #932

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Update account linking docs #932

merged 6 commits into from
Oct 10, 2024

Conversation

sisyphusSmiling
Copy link
Contributor

Closes: #924

Description

  • Updates account linking docs for Cadence 1.0
  • TODO: Enhance error messages

@sisyphusSmiling sisyphusSmiling added documentation Improvements or additions to documentation Cadence 1.0 labels Oct 4, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this Oct 4, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 6:45pm

joshuahannan
joshuahannan approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're welcome to do the error message updates in a separate PR if you want to just merge this. Updating to Cadence 1.0 is a higher priority than that

docs/build/guides/account-linking/child-accounts.md Show resolved Hide resolved
docs/build/guides/account-linking/child-accounts.md Outdated Show resolved Hide resolved
docs/build/guides/account-linking/index.md Outdated Show resolved Hide resolved
@sisyphusSmiling @joshuahannan
Apply suggestions from code review
c63ba2f 
Co-authored-by: Joshua Hannan <hannanjoshua19@gmail.com>
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review October 10, 2024 18:44
@sisyphusSmiling sisyphusSmiling merged commit 827ab11 into main Oct 10, 2024
3 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/update-account-linking branch October 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahannan joshuahannan joshuahannan approved these changes

@nvdtf nvdtf Awaiting requested review from nvdtf

Assignees

@sisyphusSmiling sisyphusSmiling

Labels
Cadence 1.0 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Account Linking Docs for Cadence 1.0 and better error messages
2 participants
@sisyphusSmiling @joshuahannan