Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message #265

Merged
merged 5 commits into from
Dec 17, 2021
Merged

Fix error message #265

merged 5 commits into from
Dec 17, 2021

Conversation

jordanschalm
Copy link
Member

No description provided.

Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Make sure you run make test to rebuild the contracts

@jordanschalm
Copy link
Member Author

jordanschalm commented Dec 16, 2021

git diff --exit-code
bash build_crypto_dependency.sh
chmod: cannot access '/home/runner/go/pkg/mod/github.com/onflow/flow-go/crypto@v0.21.3': No such file or directory
build_crypto_dependency.sh: line 17: cd: /home/runner/go/pkg/mod/github.com/onflow/flow-go/crypto@v0.21.3: No such file or directory
go test ./... --tags relic
# github.com/onflow/flow-go/crypto
In file included from /home/runner/go/pkg/mod/github.com/onflow/flow-go/crypto@v0.23.3/bls.go:32:
Error: /home/runner/go/pkg/mod/github.com/onflow/flow-go/crypto@v0.23.3/bls_include.h:8:10: fatal error: relic.h: No such file or directory
    8 | #include "relic.h"
      |          ^~~~~~~~~
compilation terminated.

Have you seen this one before @joshuahannan ?

@joshuahannan
Copy link
Member

hmm. I haven't seen that before, but I just tried it and that happened to me. Not really sure why though. @tarakby might have an idea?

@tarakby
Copy link
Contributor

tarakby commented Dec 16, 2021

I'll look at the branch and make a commit shortly

@tarakby
Copy link
Contributor

tarakby commented Dec 16, 2021

If you upgrade the crypto lib version, we need to mirror it here as well : https://github.com/onflow/flow-core-contracts/blob/jordan/hf/fix-error-msg/lib/go/test/build_crypto_dependency.sh#L7-L9

It's manual for now, but there is a PR to change this in flow-go, and it's gonna be updated in flow-core-contract too.

[ update ] I am not able to push changes to this repo for some reason, please let me know if fixing the version in the script above to 0.23.3 didn't help. @jordanschalm

@jordanschalm jordanschalm merged commit 0a25d77 into master Dec 17, 2021
@jordanschalm jordanschalm deleted the jordan/hf/fix-error-msg branch December 17, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants