-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error message #265
Fix error message #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Make sure you run make test
to rebuild the contracts
Have you seen this one before @joshuahannan ? |
hmm. I haven't seen that before, but I just tried it and that happened to me. Not really sure why though. @tarakby might have an idea? |
I'll look at the branch and make a commit shortly |
If you upgrade the crypto lib version, we need to mirror it here as well : https://github.com/onflow/flow-core-contracts/blob/jordan/hf/fix-error-msg/lib/go/test/build_crypto_dependency.sh#L7-L9 It's manual for now, but there is a PR to change this in flow-go, and it's gonna be updated in flow-core-contract too. [ update ] I am not able to push changes to this repo for some reason, please let me know if fixing the version in the script above to 0.23.3 didn't help. @jordanschalm |
No description provided.