-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFM Recovery Service Event and Transaction #440
Open
kc1116
wants to merge
65
commits into
feature/efm-recovery
Choose a base branch
from
khalil/5639-efm-recovery-transaction
base: feature/efm-recovery
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
f645974
efm recovery transaction
kc1116 3b3a9ec
use provided recovery epoch counter as the source of truth
kc1116 52ff178
add proper line indentation
kc1116 9f8ceed
update assets
kc1116 dd90e0e
define ResultSubmission struct
jordanschalm 7638aeb
annotate required changes
jordanschalm 4e0bc0c
setup test framework
jordanschalm 22ba195
add preliminary new fields to EpochCommit
jordanschalm e37f616
add submission tracker sketch
jordanschalm 4a0b5dd
Apply suggestions from code review
kc1116 e493a46
Apply suggestions from code review
kc1116 1b411fb
adjust recover transaction logic
kc1116 6b9a7fa
move recoverEpochPreChecks call to emitEpochRecoverEvent
kc1116 0a508af
fix broken sentence
kc1116 0e0ad05
add comment describing unsafeAllowOverwrite
kc1116 fd6ddfa
use previous syntax for randomSource generation
kc1116 e2323ee
replace usage of numViewsInStakingAuction and numViewsInDKGPhase
kc1116 435a55d
add godoc for convertClusterQcsCdc
kc1116 48a491c
add additional test cases
kc1116 26039c5
ResultSubmission tests
jordanschalm 88cd509
ResultSubmission docs
jordanschalm 829586b
addSubmission method
jordanschalm db7aa57
add tx todos
jordanschalm 14a70ab
add init test, validation on ResultSubmission init
jordanschalm c6e6369
test comments
jordanschalm cb02364
basic SubmissionTracker tests
jordanschalm e694f71
update other contract methods to use SubmissionTracker
jordanschalm 854a570
add dummy values for EpochCommit event
jordanschalm 257ddb6
add docs
jordanschalm 5d9f137
add exceedsThreshold test
jordanschalm 94c8cbb
Merge branch 'feature/efm-recovery' into jord/6213-dkg-mapping
jordanschalm 027e41d
update FlowEpoch to compile
jordanschalm b1afc65
update transactions
jordanschalm 56b12c1
improve representation for "empty submissions"
jordanschalm 507a454
add test for empty submission
jordanschalm a9d24b4
test empty submission exceeds threshold
jordanschalm 023faed
fix go test: send submission
jordanschalm 5f236fb
wip
jordanschalm 423fb44
remove '
jordanschalm 23ade80
incredibly, the tests are passing
jordanschalm 8f669f1
note where tests still need updating
jordanschalm 060fbb5
consistent terminology: empty submission
jordanschalm 3553260
resolve some todos
jordanschalm 9db9ab8
fix empty submission dkg tests
jordanschalm 135cad6
fix epoch tests
jordanschalm 80f1f91
rename publish admin script
jordanschalm 1fd997b
store as much as possible in EpochMetadata
jordanschalm 9b623b3
build static files
jordanschalm 3e32ac5
make more functions view
jordanschalm af7e508
fix test
jordanschalm 59b7108
add dkgIdMapping
kc1116 07090b8
rename isValidNilSubmission
jordanschalm 496f9f8
Merge branch 'jord/6213-dkg-mapping' into khalil/5639-efm-recovery-tr…
jordanschalm 8dae842
Updated epoch recovery tx to accept dkg group key as well as emitting…
durkmurder ed047b9
update error messages
jordanschalm 3aee4ca
go generate
jordanschalm 50e054a
Apply suggestions from code review
jordanschalm 526bdbe
2nd pass over error messages
jordanschalm ecbf7bb
Merge branch 'jord/6213-dkg-mapping' of github.com:onflow/flow-core-c…
jordanschalm 464db6d
fix empty whiteboard message test
jordanschalm 4e09f85
improve post whiteboard message test
jordanschalm 6931e78
rm dupe test
jordanschalm f292cc7
address remaining todos in tests
jordanschalm afacbe7
Merge branch 'jord/6213-dkg-mapping' into khalil/5639-efm-recovery-tr…
jordanschalm 9a7af20
Merge branch 'feature/efm-recovery' into khalil/5639-efm-recovery-tra…
jordanschalm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any pre-conditions we can do here to verify anything?