Updates batch unlock to only publish if needed #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kay-Zee
approved these changes
Sep 9, 2024
| let unlockingBadAccountCap = admin.capabilities.storage.issue<&{Address: UFix64}>(/storage/unlockingBadAccounts) | ||
| admin.capabilities.publish(unlockingBadAccountCap, at: /public/unlockingBadAccounts) | ||
| let unlockingBadAccountCap = admin.capabilities.get<&{Address: UFix64}>(/public/unlockingBadAccounts) | ||
| if !unlockingBadAccountCap.check() { |
There was a problem hiding this comment.
check() returns true if it exists?
| let unlockingBadAccountCap = admin.capabilities.get<&{Address: UFix64}>(/public/unlockingBadAccounts) | ||
| if !unlockingBadAccountCap.check() { | ||
| let unlockingBadAccountCap = admin.capabilities.storage.issue<&{Address: UFix64}>(/storage/unlockingBadAccounts) | ||
| admin.capabilities.unpublish(/public/unlockingBadAccounts) |
There was a problem hiding this comment.
I'm guessing unpublishing a non-existent path is just a no-op?
There was a problem hiding this comment.
correct, nothing will happen if there isn't anything there
| admin.capabilities.publish(unlockingBadAccountCap, at: /public/unlockingBadAccounts) | ||
| let unlockingBadAccountCap = admin.capabilities.get<&{Address: UFix64}>(/public/unlockingBadAccounts) | ||
| if !unlockingBadAccountCap.check() { | ||
| let unlockingBadAccountCap = admin.capabilities.storage.issue<&{Address: UFix64}>(/storage/unlockingBadAccounts) |
There was a problem hiding this comment.
i guess the extra let is just shadowing this var, which isn't a problem since it's only used here in this if.
There was a problem hiding this comment.
yeah, shouldn't be a problem to shadow it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the transaction to unlock tokens in a batch of accounts to only publish a capability to the bad accounts dictionary if one already wasn't there
Edit: Also updates the emulator and CLI versions to ensure the tests pass and removes mentions of previewnet