Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flow-go to include bootstrapping with NFT and Metadata Views #443

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

janezpodhostnik
Copy link
Contributor

Description

see onflow/flow-go#4536

I removed the three contracts from common contracts as FVM bootstrapping now already adds those.


For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #443 (ecad54e) into master (ebdcc45) will decrease coverage by 0.32%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #443      +/-   ##
==========================================
- Coverage   54.51%   54.19%   -0.32%     
==========================================
  Files          27       27              
  Lines        3590     3572      -18     
==========================================
- Hits         1957     1936      -21     
- Misses       1473     1476       +3     
  Partials      160      160              
Flag Coverage Δ
unittests 54.19% <ø> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
emulator/contracts.go 69.23% <ø> (-5.77%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@janezpodhostnik janezpodhostnik force-pushed the janez/bootstrap-with-metadata-views branch from ecad54e to 9d4aa56 Compare July 18, 2023 16:46
@janezpodhostnik janezpodhostnik merged commit ceba8ac into master Jul 18, 2023
@janezpodhostnik janezpodhostnik deleted the janez/bootstrap-with-metadata-views branch July 18, 2023 17:00
@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants