Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] fix unsafe random #458

Closed
wants to merge 322 commits into from
Closed

[WIP] fix unsafe random #458

wants to merge 322 commits into from

Conversation

tarakby
Copy link
Contributor

@tarakby tarakby commented Aug 4, 2023 •
edited
Loading

blocked by a flow-go PR: onflow/flow-go#4604

Closes onflow/cadence#2691

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

psiemens and others added 30 commits April 8, 2020 19:02
@psiemens
Update store.go
0cbdb7c
@psiemens
Update memstore.go
2b0ef0e
@psiemens
Update mocks
3efa550
@psiemens
Store results in pending block
37432d3
@psiemens
Add GetTransactionResult method
60d216a
@psiemens
Update existing tests to use GetTransactionResult
4e7a6c0
@psiemens
Add tests for GetTransactionResult
e3f1f6f
@psiemens
Update transaction_test.go
6010769
@psiemens
Update flow-go-sdk to e7fbd942ae6c
a89ee59
@psiemens
Implement GetTransactionResult method
a5bad75
@psiemens
Add happy path test for GetTransactionResult
7febc42
@psiemens
Rename TransactionStatus constants
9b68d95
@psiemens
Update transaction_test.go
2f34751
@psiemens
Include execution status and error in transaction result
c17cf52
@psiemens
Update go.sum
1554617
@psiemens
Merge pull request #11 from dapperlabs/peter/3109-transaction-results
8b87d5b 
Store transaction results, GetTransactionResult RPC method
@Kay-Zee
Add execute script at block, and bump sdk version
22b5c15
@Kay-Zee
Merge branch 'master' into kan/update-emulator-for-examples
5e64db3
@Kay-Zee
Merge pull request #12 from dapperlabs/kan/update-emulator-for-examples
4b78c87 
Kan/update emulator for examples
@psiemens
Verify transactions using new format
5190f41
@psiemens
Update protobuf and SDK dependencies
5c6e0ed
@psiemens
Remove account keys from all tests and examples
3f9b77b
@psiemens
Update computer.go
5751e83
@psiemens
Update transaction_test.go
1aed724
@psiemens
Update emulator tests to include payload signatures
54c20b4
@psiemens
Fix examples
69beead
@psiemens
Update backend_test.go
bf8aa93
@psiemens
Update blockchain.go
e880311
@psiemens
Fix transaction missing payer test
f4bb7c9
@psiemens
Validate proposal key, payload and envelope signatures
f55c767
turbolent and others added 25 commits November 4, 2020 14:57
@turbolent
Update README.md
12d6951
@turbolent
update to SDK v0.12.0
020b9f2
@turbolent
adjust tests
d0c484a
@turbolent
adjust remaining tests
176fd4b
@turbolent
disable AST cache
02c14c6
@turbolent
update to Go SDK v0.12.1
e45e70f
@turbolent
re-enable AST cache
a902fcb
@turbolent
update crypto to v0.11.0
acedca6
@turbolent
supply chain
dd5d87e
@turbolent
set max transaction size limit to default
e15b772
@turbolent
use simple addresses when testing transactions
505a8ea
@turbolent
enable more tests
8a12416
@turbolent
Revert "use simple addresses when testing transactions"
3ee7f31 
This reverts commit 1626873.
@turbolent
fix tests by using valid addresses
e97cf71
@turbolent
fix order of assertion arguments
2331209
@turbolent
create new account, authorizer must be different from payer
2bea1ac
Merge branch 'master' of github.com:onflow/flow-emulator
6609f45
Merge branch 'master' of github.com:onflow/flow-emulator
2631c55
Merge branch 'master' of github.com:onflow/flow-emulator
9c6f219
Merge branch 'master' of github.com:onflow/flow-emulator
4ba9f46
Merge branch 'master' of github.com:onflow/flow-emulator
e9e92e0
Merge branch 'master' of github.com:onflow/flow-emulator
c10dd49
add tx test with unsafeRandom
41fa206
add script test with unsafeRandom
32011e9
add enropy provider to fvm cotext
a4b7dbe
@tarakby tarakby self-assigned this Aug 4, 2023
@tarakby tarakby added the Bugfix label Aug 4, 2023
@tarakby
Copy link
Contributor Author

tarakby commented Aug 4, 2023

closing in favour of #459

@tarakby tarakby closed this Aug 4, 2023
@tarakby tarakby deleted the tarak/fix-unsafeRandom branch January 26, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik will be requested when the pull request is marked ready for review janezpodhostnik is a code owner

@bluesign bluesign Awaiting requested review from bluesign bluesign will be requested when the pull request is marked ready for review bluesign is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming will be requested when the pull request is marked ready for review chasefleming is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink will be requested when the pull request is marked ready for review jribbink is a code owner

@peterargue peterargue Awaiting requested review from peterargue peterargue will be requested when the pull request is marked ready for review peterargue is a code owner

Assignees

@tarakby tarakby

Labels
Bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: unsafeRandom() is not working in stable cadence on the emulator
10 participants
@tarakby @psiemens @Kay-Zee @turbolent @joshuahannan @m4ksio @philipstanislaus @benjaminkvm @vishalchangrani @janezpodhostnik