-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Use Indexed height when checking payer balance #724
Closed
AndriiDiachuk
wants to merge
14
commits into
onflow:master
from
AndriiDiachuk:use-indexed-height-for-payer-balance-check
Closed
[Access] Use Indexed height when checking payer balance #724
AndriiDiachuk
wants to merge
14
commits into
onflow:master
from
AndriiDiachuk:use-indexed-height-for-payer-balance-check
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiDiachuk
requested review from
sideninja,
turbolent,
janezpodhostnik,
bluesign,
chasefleming and
jribbink
as code owners
August 7, 2024 12:25
peterargue
approved these changes
Aug 29, 2024
@AndriiDiachuk please fix the merge conflict |
I will do it after replace statement from another PR is removed. |
@peterargue Merged with latest changes, should me ready for merge. |
janezpodhostnik
requested changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just that one linting issue.
zhangchiqing
approved these changes
Sep 27, 2024
replaced by #755 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR new
IndexedHeight
method was added as part of theBlocks
interface.Related PR: onflow/flow-go#6292