Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flow-go Components for composing #682

Open
wants to merge 7 commits into
base: feature/local-tx-reexecution
Choose a base branch
from

Conversation

janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented Nov 27, 2024

Closes: onflow/flow-go#6776
Depends on: onflow/flow-go#6769

Description

Use flow-go component model and node framework to compose the Gatway and handle shutdown.

Main advantage is that the re-use of the component management system from flow-go automatically gives us nicer error handling an resource closing on error. To use the error handling, just make sure to use irrecoverable.SignalerContext.Throw(err) for any unexpected error. This will start the shutdown procedure and properly release all resources.

Changes:

  • api/profiler.go is now a component
  • api/server.go is now a component
  • bootstrap/bootstrap.go is changed a lot and is modeled after flow-go ExecutionNodeBuilder
  • bootstrap/utils.go were moved into services/requester/key_store_component.go which is a component that handles the keystore. It should have a Close for the KMS client, but the KMS client is currently not a io.Closer (which should be addresses)
  • cmd/run/cmd.go was simplified because the startup logic is now actually in flow-go
  • models/engine.go was removed because its no longer needed
  • models/stream.go was converted into a component. This lets it force shutdown the gateway in case of an error in Notify
  • services/ingestion/engine.go is now component. In case of errors in events processing it shuts down the node.

This depends on onflow/flow-go#6769


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@janezpodhostnik janezpodhostnik self-assigned this Nov 27, 2024
Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Base automatically changed from janez/config-instance to janez/switch-to-flow-go-metrics-server November 29, 2024 14:28
@janezpodhostnik janezpodhostnik changed the base branch from janez/switch-to-flow-go-metrics-server to janez/config-instance-2 November 29, 2024 14:36
@janezpodhostnik janezpodhostnik changed the base branch from janez/config-instance-2 to feature/local-tx-reexecution December 2, 2024 13:22
@janezpodhostnik janezpodhostnik force-pushed the janez/use-flow-go-components branch from 33d6278 to 67136f9 Compare December 2, 2024 15:11
@janezpodhostnik janezpodhostnik force-pushed the janez/use-flow-go-components branch 2 times, most recently from 0d7a9f4 to 743e9fb Compare December 13, 2024 20:27
@janezpodhostnik janezpodhostnik force-pushed the janez/use-flow-go-components branch from 743e9fb to a208530 Compare December 13, 2024 20:39
@janezpodhostnik janezpodhostnik force-pushed the janez/use-flow-go-components branch from 9e3947b to 50d77d2 Compare December 16, 2024 15:17
@janezpodhostnik janezpodhostnik marked this pull request as ready for review December 16, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant