fix returning before unlock and add warning log when randomness fails

cmd/bootstrap/cmd/clusters.go

@@ -38,8 +38,7 @@ func constructClusterAssignment(partnerNodes, internalNodes []model.NodeInfo) (f
 	}
 
 	// shuffle both collector lists based on a non-deterministic algorithm
-	var err error
-	partners, err = partners.Shuffle()
+	partners, err := partners.Shuffle()
 	if err != nil {
 		log.Fatal().Err(err).Msg("could not shuffle partners")
 	}

engine/execution/computation/query/executor.go

@@ -113,11 +113,11 @@ func (e *QueryExecutor) ExecuteScript(
 	// TODO: this is a temporary measure, we could remove this in the future
 	if e.logger.Debug().Enabled() {
 		e.rngLock.Lock()
+		defer e.rngLock.Unlock()
 		trackerID, err := rand.Uint32()
 		if err != nil {
 			return nil, fmt.Errorf("failed to generate trackerID: %w", err)
 		}
-		e.rngLock.Unlock()
 
 		trackedLogger := e.logger.With().Hex("script_hex", script).Uint32("trackerID", trackerID).Logger()
 		trackedLogger.Debug().Msg("script is sent for execution")

storage/badger/cleaner.go

@@ -89,6 +89,7 @@ func (c *Cleaner) nextWaitDuration() time.Duration {
 		// In this specific case, `utils/rand` only errors if the system randomness fails
 		// which is a symptom of a wider failure. Many other node components would catch such
 		// a failure.
+		c.log.Warn().Msg("jitter is zero beacuse system randomness has failed")
 		jitter = 0
 	}
 	return time.Duration(c.interval.Nanoseconds() + int64(jitter))