Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TPS loader] Make TPS loader input more flexible #5490

Closed
1 task
Tracked by #5489
janezpodhostnik opened this issue Mar 1, 2024 · 0 comments · Fixed by #5548
Closed
1 task
Tracked by #5489

[TPS loader] Make TPS loader input more flexible #5490

janezpodhostnik opened this issue Mar 1, 2024 · 0 comments · Fixed by #5548
Assignees

Comments

@janezpodhostnik
Copy link
Contributor

Problem Definition

TPS loader input is not detailed enough.

Currently you start the loader like this:

go run ../benchmark/cmd/ci -log-level info -git-repo-path ../../ -tps-initial 800 -tps-min 1 -tps-max 1200 -duration 30m -load-type "token-tranfer"

The automated job can currently change the load type but not any other parameters.

This causes issues with loads where an initial starting TPS of 800 is way to much and it breaks the whole run.
This is also an issue if we would like to specify extra parameters for any load type (e.i.: "create-account" load type could receive a parameter on how many accounts to create per transaction)

Proposed Solution

The input to the command could be a json or yaml file path, which would then be parsed into the parameters needed for that run.

name: "token transfer"
run_parameters:
  max_tps: 1200
  min_tps: 1
  initial_tps: 800
  duration: 30m
load_parameters:
  transfers_per_transaction: 1

Definition of Done

  • The TPS automated loader can use different load types where each load type specifies its own parameters
@janezpodhostnik janezpodhostnik self-assigned this Mar 1, 2024
@janezpodhostnik janezpodhostnik changed the title [TPS loader] Change input parameters format [TPS loader] Make TPS loader input more flexible Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant