Improve CI TPS metering input #5548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5548 +/- ##
==========================================
+ Coverage 55.65% 55.70% +0.05%
==========================================
Files 1041 1033 -8
Lines 101935 101503 -432
==========================================
- Hits 56729 56544 -185
+ Misses 40846 40609 -237
+ Partials 4360 4350 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
approved these changes
Apr 2, 2024
integration/benchmark/cmd/ci/main.go
Outdated
| initialTPSFlag := flag.Int("tps-initial", 10, "starting transactions per second") | ||
| maxTPSFlag := flag.Int("tps-max", *initialTPSFlag, "maximum transactions per second allowed") | ||
| minTPSFlag := flag.Int("tps-min", *initialTPSFlag, "minimum transactions per second allowed") | ||
| loadTypeFlag := flag.String("load-type", string(defaultLoadType), "load type (token-transfer / const-exec / evm from the load config file)") |
There was a problem hiding this comment.
Suggested change
| loadTypeFlag := flag.String("load-type", string(defaultLoadType), "load type (token-transfer / const-exec / evm from the load config file)") | |
| loadTypeFlag := flag.String("load-type", string(defaultLoadType), "load type (token-transfer / const-exec / evm) from the load config file") |
sideninja
reviewed
Apr 12, 2024
| @@ -21,7 +21,8 @@ commits_file="/opt/commits.recent" | |||
| load_types=("token-transfer" "create-account" "ledger-heavy" "evm-transfer") | |||
|
|
|||
| # get the merge commits from the last week from master ordered by author date | |||
| for commit in $(git log --merges --first-parent --format="%S:%H" origin/master --since '1 week' --author-date-order ) | |||
| # TEMPORARY: DO NOT MERGE!! | |||
There was a problem hiding this comment.
ah thanks for that :) , I forgot about it!
I wish we had CI for this. Something like this https://github.com/JJ/github-pr-contains-action but listening to "DO NOT MERGE".
sideninja
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5490
CI TPS metering can now optionally take load parameters from a yaml file.
This PR also contains a small cleanup of unused TPS monitor features.