Update golangci, trying to fix lint #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kay-Zee
force-pushed
the
kan/fix-lint
branch
3 times, most recently
from
4a70353
to
b5bad68
Compare
zhangchiqing
approved these changes
Oct 21, 2021
|
I noticed the linter in makefile is not used by the linter job in CI. This means developers might get different results locally using |
peterargue
approved these changes
Oct 21, 2021
gomisha
approved these changes
Oct 21, 2021
The CI action is nice to have, as it gives more features, and allows slightly more control (also, the golangci team obviously suggests using golangci action instead of your own) They do use the same config file, so should return the same results |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 22, 2021
1509: Update golangci, trying to fix lint r=Kay-Zee a=Kay-Zee This updates the golangci action to just use the latest v2 action, which is recommended for the action. Also, skipping the PKG cache because of all the File Exists error. Will have to follow: golangci/golangci-lint-action#244 to see when this is resolved. (though lint is one of the faster jobs, so it's fine even if we skip the cache) Lastly, I'm suggesting we skip the `unused` lint for TEST FILES ONLY, as there are many cases where we want to use `t.Skip()` to quarantine, but then it causes "unused" errors. This will resolve those cases and better allow us to use `t.Skip()` Co-authored-by: Kay-Zee <kan@axiomzen.co>
|
Build failed: |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 22, 2021
1509: Update golangci, trying to fix lint r=Kay-Zee a=Kay-Zee This updates the golangci action to just use the latest v2 action, which is recommended for the action. Also, skipping the PKG cache because of all the File Exists error. Will have to follow: golangci/golangci-lint-action#244 to see when this is resolved. (though lint is one of the faster jobs, so it's fine even if we skip the cache) Lastly, I'm suggesting we skip the `unused` lint for TEST FILES ONLY, as there are many cases where we want to use `t.Skip()` to quarantine, but then it causes "unused" errors. This will resolve those cases and better allow us to use `t.Skip()` Co-authored-by: Kay-Zee <kan@axiomzen.co>
|
Build failed: |
Use more up-to-date v2 for golang lint Skip pkg cache
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the golangci action to just use the latest v2 action, which is recommended for the action.
Also, skipping the PKG cache because of all the File Exists error. Will have to follow: golangci/golangci-lint-action#244 to see when this is resolved. (though lint is one of the faster jobs, so it's fine even if we skip the cache)
Lastly, I'm suggesting we skip the
unusedlint for TEST FILES ONLY, as there are many cases where we want to uset.Skip()to quarantine, but then it causes "unused" errors. This will resolve those cases and better allow us to uset.Skip()