-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update golangci, trying to fix lint #1509
Conversation
4a70353
to
b5bad68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks for the fix!
I noticed the linter in makefile is not used by the linter job in CI. This means developers might get different results locally using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to disable unused
linter for (skipped) tests
The CI action is nice to have, as it gives more features, and allows slightly more control (also, the golangci team obviously suggests using golangci action instead of your own) They do use the same config file, so should return the same results |
bors merge |
1509: Update golangci, trying to fix lint r=Kay-Zee a=Kay-Zee This updates the golangci action to just use the latest v2 action, which is recommended for the action. Also, skipping the PKG cache because of all the File Exists error. Will have to follow: golangci/golangci-lint-action#244 to see when this is resolved. (though lint is one of the faster jobs, so it's fine even if we skip the cache) Lastly, I'm suggesting we skip the `unused` lint for TEST FILES ONLY, as there are many cases where we want to use `t.Skip()` to quarantine, but then it causes "unused" errors. This will resolve those cases and better allow us to use `t.Skip()` Co-authored-by: Kay-Zee <kan@axiomzen.co>
Build failed: |
bors merge |
1509: Update golangci, trying to fix lint r=Kay-Zee a=Kay-Zee This updates the golangci action to just use the latest v2 action, which is recommended for the action. Also, skipping the PKG cache because of all the File Exists error. Will have to follow: golangci/golangci-lint-action#244 to see when this is resolved. (though lint is one of the faster jobs, so it's fine even if we skip the cache) Lastly, I'm suggesting we skip the `unused` lint for TEST FILES ONLY, as there are many cases where we want to use `t.Skip()` to quarantine, but then it causes "unused" errors. This will resolve those cases and better allow us to use `t.Skip()` Co-authored-by: Kay-Zee <kan@axiomzen.co>
Build failed: |
Use more up-to-date v2 for golang lint Skip pkg cache
bors merge |
This updates the golangci action to just use the latest v2 action, which is recommended for the action.
Also, skipping the PKG cache because of all the File Exists error. Will have to follow: golangci/golangci-lint-action#244 to see when this is resolved. (though lint is one of the faster jobs, so it's fine even if we skip the cache)
Lastly, I'm suggesting we skip the
unused
lint for TEST FILES ONLY, as there are many cases where we want to uset.Skip()
to quarantine, but then it causes "unused" errors. This will resolve those cases and better allow us to uset.Skip()