Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Cadence v0.39.9 #4472

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Update to Cadence v0.39.9 #4472

merged 1 commit into from
Jun 13, 2023

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Jun 13, 2023

@turbolent turbolent requested review from a team June 13, 2023 00:38
@turbolent turbolent requested a review from gomisha as a code owner June 13, 2023 00:38
@turbolent turbolent self-assigned this Jun 13, 2023
@turbolent
Copy link
Member Author

bors merge

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #4472 (ad6f8a5) into v0.31 (80988fe) will decrease coverage by 4.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            v0.31    #4472      +/-   ##
==========================================
- Coverage   56.69%   52.52%   -4.18%     
==========================================
  Files         814      693     -121     
  Lines       75721    65161   -10560     
==========================================
- Hits        42931    34223    -8708     
+ Misses      29524    28568     -956     
+ Partials     3266     2370     -896     
Flag Coverage Δ
unittests 52.52% <ø> (-4.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 285 files with indirect coverage changes

@github-actions
Copy link
Contributor

FVM Benchstat comparison

This branch with compared with the base branch onflow:v0.31 commit 80988fe

The command (for i in {1..7}; do go test ./fvm ./engine/execution/computation --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-2128ms ± 3%128ms ± 4%~(p=0.731 n=7+6)
RuntimeTransaction/convert_int_to_string-240.0ms ± 3%40.4ms ± 3%~(p=0.699 n=6+6)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-243.0ms ± 4%42.9ms ±13%~(p=0.710 n=7+7)
RuntimeTransaction/get_signer_address-239.0ms ± 3%39.5ms ±11%~(p=1.000 n=6+7)
RuntimeTransaction/get_public_account-241.8ms ± 3%41.4ms ± 3%~(p=0.383 n=7+7)
RuntimeTransaction/get_account_and_get_balance-2306ms ± 2%300ms ± 3%~(p=0.053 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-244.3ms ± 2%43.8ms ± 6%~(p=0.445 n=6+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2269ms ± 2%268ms ± 5%~(p=0.620 n=7+7)
RuntimeTransaction/get_signer_vault-247.6ms ± 2%46.8ms ± 6%~(p=0.620 n=7+7)
RuntimeTransaction/get_signer_receiver-259.2ms ± 7%58.5ms ± 4%~(p=0.805 n=7+7)
RuntimeTransaction/transfer_tokens-2222ms ± 3%218ms ± 2%~(p=0.073 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-246.1ms ± 3%46.2ms ± 4%~(p=0.945 n=7+6)
RuntimeTransaction/load_and_save_long_string_on_signers_address-290.7ms ± 3%88.9ms ± 2%~(p=0.073 n=7+6)
RuntimeTransaction/emit_event-256.0ms ± 7%53.8ms ± 6%~(p=0.073 n=7+7)
RuntimeTransaction/borrow_array_from_storage-2154ms ± 3%151ms ± 3%~(p=0.209 n=7+7)
RuntimeTransaction/copy_array_from_storage-2153ms ± 2%151ms ± 2%~(p=0.234 n=6+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-24.97s ± 1%4.94s ± 1%~(p=0.138 n=7+6)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/create_new_account-2897ms ± 1%888ms ± 1%−1.00%(p=0.035 n=7+6)
RuntimeTransaction/get_account_and_get_available_balance-2304ms ± 1%297ms ± 3%−2.13%(p=0.022 n=6+7)
RuntimeTransaction/reference_tx-239.0ms ± 2%37.4ms ± 5%−4.14%(p=0.015 n=6+6)
RuntimeTransaction/call_empty_contract_function-243.0ms ± 4%41.2ms ± 3%−4.32%(p=0.014 n=7+6)
 
alloc/opdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeNFTBatchTransfer-253.2MB ± 2%54.4MB ± 6%~(p=0.383 n=7+7)
RuntimeTransaction/reference_tx-235.9MB ± 2%35.9MB ± 4%~(p=0.710 n=7+7)
RuntimeTransaction/convert_int_to_string-236.3MB ± 4%37.2MB ± 3%~(p=0.073 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-236.5MB ± 4%37.1MB ± 3%~(p=0.318 n=7+7)
RuntimeTransaction/get_signer_address-236.0MB ± 2%36.3MB ± 3%~(p=0.710 n=7+7)
RuntimeTransaction/get_public_account-237.8MB ± 4%37.4MB ± 4%~(p=0.318 n=7+7)
RuntimeTransaction/get_account_and_get_balance-2123MB ± 2%122MB ± 3%~(p=0.383 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-2109MB ± 3%109MB ± 3%~(p=0.620 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-237.8MB ± 3%37.6MB ± 6%~(p=0.620 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-2105MB ± 3%106MB ± 2%~(p=0.620 n=7+7)
RuntimeTransaction/get_signer_vault-238.3MB ± 3%38.3MB ± 4%~(p=1.000 n=7+7)
RuntimeTransaction/get_signer_receiver-241.4MB ± 4%41.6MB ± 5%~(p=0.710 n=7+7)
RuntimeTransaction/transfer_tokens-281.5MB ± 4%81.0MB ± 3%~(p=0.836 n=7+6)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-237.4MB ± 3%37.7MB ± 4%~(p=0.620 n=7+7)
RuntimeTransaction/load_and_save_long_string_on_signers_address-254.3MB ± 3%53.8MB ± 4%~(p=0.383 n=7+7)
RuntimeTransaction/create_new_account-2184MB ± 3%186MB ± 0%~(p=0.534 n=7+6)
RuntimeTransaction/call_empty_contract_function-236.9MB ± 4%36.4MB ± 4%~(p=0.456 n=7+7)
RuntimeTransaction/emit_event-242.2MB ± 5%40.8MB ± 5%~(p=0.097 n=7+7)
RuntimeTransaction/borrow_array_from_storage-272.7MB ± 4%72.1MB ± 4%~(p=0.620 n=7+7)
RuntimeTransaction/copy_array_from_storage-284.1MB ± 1%83.0MB ± 3%~(p=0.259 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-21.23GB ± 1%1.23GB ± 1%~(p=0.620 n=7+7)
 
allocs/opdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/transfer_tokens-2861k ± 0%862k ± 0%+0.01%(p=0.003 n=7+7)
RuntimeNFTBatchTransfer-2281k ± 0%281k ± 0%~(p=0.735 n=7+7)
RuntimeTransaction/reference_tx-291.6k ± 0%91.6k ± 0%~(p=0.071 n=7+7)
RuntimeTransaction/convert_int_to_string-2104k ± 0%104k ± 0%~(p=0.175 n=7+7)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2115k ± 0%115k ± 0%~(p=0.559 n=7+7)
RuntimeTransaction/get_signer_address-295.8k ± 0%95.8k ± 0%~(p=0.826 n=7+7)
RuntimeTransaction/get_public_account-2120k ± 0%120k ± 0%~(p=0.826 n=7+7)
RuntimeTransaction/get_account_and_get_balance-21.33M ± 0%1.33M ± 0%~(p=0.805 n=7+7)
RuntimeTransaction/get_account_and_get_available_balance-21.29M ± 0%1.29M ± 0%~(p=0.733 n=7+7)
RuntimeTransaction/get_account_and_get_storage_used-2131k ± 0%131k ± 0%~(p=0.684 n=7+7)
RuntimeTransaction/get_account_and_get_storage_capacity-21.16M ± 0%1.16M ± 0%~(p=0.902 n=7+7)
RuntimeTransaction/get_signer_vault-2136k ± 0%136k ± 0%~(p=0.727 n=7+7)
RuntimeTransaction/get_signer_receiver-2223k ± 0%223k ± 0%~(p=0.221 n=7+7)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2143k ± 0%143k ± 0%~(p=0.090 n=7+7)
RuntimeTransaction/create_new_account-22.36M ± 0%2.36M ± 0%~(p=0.710 n=7+7)
RuntimeTransaction/call_empty_contract_function-2109k ± 0%109k ± 0%~(p=0.347 n=7+6)
RuntimeTransaction/emit_event-2151k ± 0%151k ± 0%~(p=0.917 n=6+7)
RuntimeTransaction/borrow_array_from_storage-2371k ± 0%371k ± 0%~(p=0.383 n=7+7)
RuntimeTransaction/copy_array_from_storage-2304k ± 0%304k ± 0%~(p=0.833 n=7+7)
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-217.7M ± 0%17.7M ± 0%~(p=1.000 n=7+7)
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/load_and_save_long_string_on_signers_address-2225k ± 0%225k ± 0%−0.01%(p=0.024 n=6+6)
 
computationdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-2202 ± 0%202 ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2502 ± 0%502 ± 0%~(all equal)
RuntimeTransaction/get_signer_address-2302 ± 0%302 ± 0%~(all equal)
RuntimeTransaction/get_public_account-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_balance-21.00k ± 0%1.00k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_available_balance-23.10k ± 0%3.10k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-21.70k ± 0%1.70k ± 0%~(all equal)
RuntimeTransaction/get_signer_vault-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_signer_receiver-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/transfer_tokens-23.50k ± 0%3.50k ± 0%~(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/create_new_account-2202 ± 0%202 ± 0%~(all equal)
RuntimeTransaction/call_empty_contract_function-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/emit_event-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/borrow_array_from_storage-22.60k ± 0%2.60k ± 0%~(all equal)
RuntimeTransaction/copy_array_from_storage-22.60k ± 0%2.60k ± 0%~(all equal)
 
interactionsdelta
pkg:github.com/onflow/flow-go/fvm goos:linux goarch:amd64
RuntimeTransaction/reference_tx-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_signer_address-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_public_account-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_balance-246.4k ± 0%46.4k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_available_balance-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_used-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_signer_vault-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/get_signer_receiver-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/transfer_tokens-238.1k ± 0%38.1k ± 0%~(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-238.3k ± 0%38.3k ± 0%~(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-242.1k ± 0%42.1k ± 0%~(all equal)
RuntimeTransaction/create_new_account-284.3k ± 0%84.3k ± 0%~(all equal)
RuntimeTransaction/call_empty_contract_function-238.3k ± 0%38.3k ± 0%~(all equal)
RuntimeTransaction/emit_event-238.3k ± 0%38.3k ± 0%~(all equal)
RuntimeTransaction/borrow_array_from_storage-243.4k ± 0%43.4k ± 0%~(p=0.385 n=6+7)
RuntimeTransaction/copy_array_from_storage-243.4k ± 0%43.4k ± 0%~(all equal)
 
us/txdelta
pkg:github.com/onflow/flow-go/engine/execution/computation goos:linux goarch:amd64
ComputeBlock/16/cols/128/txes-22.43k ± 1%2.41k ± 1%~(p=0.138 n=7+6)
 

@bors bors bot merged commit 71d1154 into v0.31 Jun 13, 2023
@bors bors bot deleted the bastian/v0.31-cadence-v0.39.9 branch June 13, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants