Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification Node documentation #4528

Merged
merged 12 commits into from
Jul 12, 2023
Merged

Conversation

yhassanzadeh13
Copy link
Contributor

This PR adds a comprehensive architectural overview of the verification node.

@yhassanzadeh13 yhassanzadeh13 requested a review from ramtinms as a code owner June 27, 2023 21:54
@yhassanzadeh13 yhassanzadeh13 requested review from zhangchiqing and AlexHentschel and removed request for ramtinms June 27, 2023 21:54
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #4528 (240507a) into master (2528190) will decrease coverage by 1.81%.
The diff coverage is 48.03%.

@@            Coverage Diff             @@
##           master    #4528      +/-   ##
==========================================
- Coverage   56.25%   54.44%   -1.81%     
==========================================
  Files         653      914     +261     
  Lines       64699    85158   +20459     
==========================================
+ Hits        36396    46366    +9970     
- Misses      25362    35220    +9858     
- Partials     2941     3572     +631     
Flag Coverage Δ
unittests 54.44% <48.03%> (-1.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/scaffold.go 14.78% <0.00%> (+0.02%) ⬆️
module/metrics/herocache.go 0.00% <0.00%> (ø)
module/metrics/network.go 0.00% <0.00%> (ø)
module/metrics/noop.go 0.00% <0.00%> (ø)
network/p2p/inspector/internal/cache/cache.go 64.70% <ø> (ø)
network/p2p/middleware/middleware.go 1.71% <0.00%> (ø)
network/p2p/p2pbuilder/libp2pNodeBuilder.go 0.00% <0.00%> (ø)
utils/unittest/unittest.go 7.48% <0.00%> (-0.12%) ⬇️
network/netconf/flags.go 26.37% <50.00%> (ø)
network/p2p/tracer/internal/rpc_send_entity.go 77.77% <77.77%> (ø)
... and 4 more

... and 255 files with indirect coverage changes

@yhassanzadeh13 yhassanzadeh13 requested a review from durkmurder July 4, 2023 16:52
Copy link
Member

@zhangchiqing zhangchiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice write up!

engine/verification/Readme.md Outdated Show resolved Hide resolved
@yhassanzadeh13 yhassanzadeh13 merged commit 117fcc0 into master Jul 12, 2023
@yhassanzadeh13 yhassanzadeh13 deleted the yahya/verification-documentation branch July 12, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants