-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification Node documentation #4528
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhassanzadeh13
requested review from
zhangchiqing and
AlexHentschel
and removed request for
ramtinms
June 27, 2023 21:54
Codecov Report
@@ Coverage Diff @@
## master #4528 +/- ##
==========================================
- Coverage 56.25% 54.44% -1.81%
==========================================
Files 653 914 +261
Lines 64699 85158 +20459
==========================================
+ Hits 36396 46366 +9970
- Misses 25362 35220 +9858
- Partials 2941 3572 +631
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zhangchiqing
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice write up!
Co-authored-by: Leo Zhang <zhangchiqing@gmail.com>
durkmurder
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive architectural overview of the verification node.