[Networking] Handling iHave broken promises (and part-2 of overpromising) spams #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4566 +/- ##
=======================================
Coverage 54.47% 54.47%
=======================================
Files 914 914
Lines 85278 85290 +12
=======================================
+ Hits 46454 46464 +10
- Misses 35239 35242 +3
+ Partials 3585 3584 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…oken-promises-part-2
peterargue
approved these changes
Jul 19, 2023
| // this threshold to 10 meaning that the first 10 broken promises are ignored. This is to allow for some network churn. | ||
| // Also, per hearbeat (i.e., decay interval), the spammer is allowed to send at most 5000 ihave messages (gossip sub parameter) on aggregate, and | ||
| // excess messages are dropped (without being counted as broken promises). | ||
| func TestGossipSubIHaveBrokenPromises_Below_Threshold(t *testing.T) { |
There was a problem hiding this comment.
can this be run with t.Parallel()? same question for all the other tests
…-part-2' into yahya/6459-ihave-broken-promises-part-2
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 19, 2023
4566: [Networking] Handling iHave broken promises (and part-2 of overpromising) spams r=yhassanzadeh13 a=yhassanzadeh13 This PR introduces changes to our GossipSub parameter configurations to effectively address and mitigate iHave Broken Promise attacks. An iHave Broken Promise attack is characterized by a peer advertising an iHave (indicating they have a certain message), but failing to respond to the iWant requests for that message. We have fine-tuned the GossipSub parameters, notably `defaultBehaviourPenaltyThreshold`, `defaultBehaviourPenaltyWeight`, and `defaultBehaviourPenaltyDecay` to penalize such behavior more appropriately. The `defaultBehaviourPenaltyThreshold` is set to `10`, meaning we at most tolerate `10` RPCs containing iHave Broken Promises. The `defaultBehaviourPenaltyWeight` applies a penalty when a peer's misbehavior exceeds the threshold. The penalty is applied to the square of the difference between the misbehavior counter and the threshold, to provide a substantial disincentive for malicious peers. If a peer misbehaves more than `sqrt(2) * 10` times the threshold, they will be graylisted or disconnected. The `defaultBehaviourPenaltyDecay` is set to `0.9`, causing the misbehavior counter to decay by `10%` per decay interval. This means that peers have a chance to recover from their previous misbehavior and incentivizes improved behavior in the future. Co-authored-by: Yahya Hassanzadeh <yhassanzadeh13@ku.edu.tr> Co-authored-by: Yahya Hassanzadeh, Ph.D <yhassanzadeh@ieee.org>
|
Canceled. |
…-part-2' into yahya/6459-ihave-broken-promises-part-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to our GossipSub parameter configurations to effectively address and mitigate iHave Broken Promise attacks. An iHave Broken Promise attack is characterized by a peer advertising an iHave (indicating they have a certain message), but failing to respond to the iWant requests for that message.
We have fine-tuned the GossipSub parameters, notably
defaultBehaviourPenaltyThreshold,defaultBehaviourPenaltyWeight, anddefaultBehaviourPenaltyDecayto penalize such behavior more appropriately.The
defaultBehaviourPenaltyThresholdis set to10, meaning we at most tolerate10RPCs containing iHave Broken Promises. ThedefaultBehaviourPenaltyWeightapplies a penalty when a peer's misbehavior exceeds the threshold. The penalty is applied to the square of the difference between the misbehavior counter and the threshold, to provide a substantial disincentive for malicious peers. If a peer misbehaves more thansqrt(2) * 10times the threshold, they will be graylisted or disconnected.The
defaultBehaviourPenaltyDecayis set to0.9, causing the misbehavior counter to decay by10%per decay interval. This means that peers have a chance to recover from their previous misbehavior and incentivizes improved behavior in the future.