Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Add metrics to execution state indexer #4801

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

peterargue
Copy link
Contributor

Adds metrics to execution data indexer.

@peterargue peterargue self-assigned this Oct 5, 2023
@peterargue peterargue requested review from sideninja, koko1123 and zhangchiqing and removed request for sideninja October 5, 2023 19:45
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Attention: 116 lines in your changes are missing coverage. Please review.

Comparison is base (9c6f9ff) 55.80% compared to head (9afb31f) 55.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4801      +/-   ##
==========================================
- Coverage   55.80%   55.78%   -0.02%     
==========================================
  Files         939      940       +1     
  Lines       86922    86993      +71     
==========================================
+ Hits        48508    48532      +24     
- Misses      34764    34808      +44     
- Partials     3650     3653       +3     
Flag Coverage Δ
unittests 55.78% <9.37%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...dule/state_synchronization/indexer/indexer_core.go 87.41% <100.00%> (+0.84%) ⬆️
module/metrics/noop.go 0.00% <0.00%> (ø)
module/metrics/execution_state_indexer.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue added this pull request to the merge queue Oct 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 6, 2023
@peterargue peterargue added this pull request to the merge queue Oct 6, 2023
Merged via the queue into master with commit 2f25cfa Oct 6, 2023
36 checks passed
@peterargue peterargue deleted the petera/4798-add-indexer-metrics branch October 6, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants