Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Validate checkpoint's root hash #4830

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

peterargue
Copy link
Contributor

Closes: #4806

This PR updates the Access node's register db checkpoint loader to verify the root hash from the checkpoint matches the root hash from the protocol state.

It also removes configuration to specify the checkpoint height since it is assume (and verified) to be the root block.

@peterargue peterargue self-assigned this Oct 17, 2023
@peterargue peterargue force-pushed the petera/48060-access-verify-checkpoint-root-hash branch from 08e0eb7 to e94aadd Compare October 17, 2023 23:38
Base automatically changed from leo/validate-checkpoint-root-hash to master October 18, 2023 20:09
@peterargue peterargue enabled auto-merge October 18, 2023 20:41
@peterargue peterargue added this pull request to the merge queue Oct 18, 2023
@peterargue peterargue removed this pull request from the merge queue due to a manual request Oct 18, 2023
@peterargue peterargue enabled auto-merge October 18, 2023 21:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ac256c1) 55.85% compared to head (b203b00) 55.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4830      +/-   ##
==========================================
+ Coverage   55.85%   55.88%   +0.03%     
==========================================
  Files         944      944              
  Lines       87767    87778      +11     
==========================================
+ Hits        49022    49057      +35     
+ Misses      35056    35030      -26     
- Partials     3689     3691       +2     
Flag Coverage Δ
unittests 55.88% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...dule/state_synchronization/indexer/indexer_core.go 88.07% <100.00%> (+0.66%) ⬆️
module/metrics/noop.go 0.00% <0.00%> (ø)
module/metrics/execution_state_indexer.go 0.00% <0.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue added this pull request to the merge queue Oct 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 19, 2023
@peterargue peterargue added this pull request to the merge queue Oct 19, 2023
Merged via the queue into master with commit 12654f8 Oct 19, 2023
36 checks passed
@peterargue peterargue deleted the petera/48060-access-verify-checkpoint-root-hash branch October 19, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Compare checkpoint's root node hash to root snapshot
4 participants