-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Validate checkpoint's root hash #4830
Merged
peterargue
merged 8 commits into
master
from
petera/48060-access-verify-checkpoint-root-hash
Oct 19, 2023
Merged
[Access] Validate checkpoint's root hash #4830
peterargue
merged 8 commits into
master
from
petera/48060-access-verify-checkpoint-root-hash
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
force-pushed
the
petera/48060-access-verify-checkpoint-root-hash
branch
from
October 17, 2023 23:38
08e0eb7
to
e94aadd
Compare
zhangchiqing
approved these changes
Oct 18, 2023
…cess-verify-checkpoint-root-hash
koko1123
approved these changes
Oct 18, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4830 +/- ##
==========================================
+ Coverage 55.85% 55.88% +0.03%
==========================================
Files 944 944
Lines 87767 87778 +11
==========================================
+ Hits 49022 49057 +35
+ Misses 35056 35030 -26
- Partials 3689 3691 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 19, 2023
peterargue
deleted the
petera/48060-access-verify-checkpoint-root-hash
branch
October 19, 2023 04:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4806
This PR updates the Access node's register db checkpoint loader to verify the root hash from the checkpoint matches the root hash from the protocol state.
It also removes configuration to specify the checkpoint height since it is assume (and verified) to be the root block.