suggestions for PR #4834 #4854
Merged
suggestions for PR #4834 #4854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2023 01:15
• revised goDoc of protocol state implementation • changed `ProtocolStateEntry.PreviousEpoch` to pointer (consistent with `ProtocolStateEntry.NextEpoch`) • There should be no significant algorithmic changes. Though, I have switched the order of the if and else branches when processing an Epoch Setup event. For me, this is much more in line with the intuitive order of documentation. state/protocol/protocol_state/updater.go: • notable updates and revisions of goDoc • tried to address concerns around inconsistent handling of invariances • updated code to work with `ProtocolStateEntry.PreviousEpoch` being potentially a nil pointer storage/badger/protocol_state_test.go: • detailed goDoc revisions for test `assertRichProtocolStateValidity`
This was referenced Oct 20, 2023
|
Excellent stuff. I have made some adjustments to fix tests around root snapshots. |
durkmurder
deleted the
alex/4649-prev-epoch-refactoring-attempt_-_suggestions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested revisions for PR #4834
Summary of central changes:
model/flow/protocol_state.go:ProtocolStateEntry.PreviousEpochto pointer (consistent withProtocolStateEntry.NextEpoch)state/protocol/protocol_state/updater.go:ProtocolStateEntry.PreviousEpochbeing potentially a nil pointerstorage/badger/protocol_state_test.go:assertRichProtocolStateValidityThis PR is likely incomplete and might require tiding up some minor loose ends.