Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] beyond EVM part 7 - adding more evm-based contract types for testing #4872

Merged
merged 18 commits into from
Nov 15, 2023

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Oct 25, 2023

This PR adds a new type of test contract that can be used testing and benchmarking.

@ramtinms ramtinms marked this pull request as ready for review November 11, 2023 02:10
@ramtinms ramtinms marked this pull request as draft November 11, 2023 02:10
@ramtinms ramtinms changed the base branch from ramtin/evm-capture-tx-hashes to master November 14, 2023 23:19
…ow/flow-go into ramtin/evm-add-dummy-kitty-contract
@ramtinms ramtinms marked this pull request as ready for review November 14, 2023 23:22
@ramtinms ramtinms changed the title [FVM] beyond EVM part 8 - adding more evm-based contract types for testing [FVM] beyond EVM part 7 - adding more evm-based contract types for testing Nov 14, 2023
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccb723f) 56.02% compared to head (3eab0d8) 56.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4872      +/-   ##
==========================================
+ Coverage   56.02%   56.25%   +0.22%     
==========================================
  Files         918      969      +51     
  Lines       86351    90417    +4066     
==========================================
+ Hits        48378    50860    +2482     
- Misses      34297    35763    +1466     
- Partials     3676     3794     +118     
Flag Coverage Δ
unittests 56.25% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms enabled auto-merge November 15, 2023 07:54
@ramtinms ramtinms added this pull request to the merge queue Nov 15, 2023
Merged via the queue into master with commit c1ec969 Nov 15, 2023
54 checks passed
@ramtinms ramtinms deleted the ramtin/evm-add-dummy-kitty-contract branch November 15, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants