Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] beyond EVM part 6.1 - Implement EVMAddress.deposit #4889

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

turbolent
Copy link
Member

@turbolent turbolent commented Oct 27, 2023

Depends on #4866

Base automatically changed from bastian/new-evm-contract to ramtin/evm-integrate-into-fvm October 31, 2023 21:40
@ramtinms ramtinms changed the title [FVM] Implement EVMAddress.deposit [FVM] beyond EVM part 6 - Implement EVMAddress.deposit Oct 31, 2023
@ramtinms ramtinms changed the title [FVM] beyond EVM part 6 - Implement EVMAddress.deposit [FVM] beyond EVM part 6.1 - Implement EVMAddress.deposit Oct 31, 2023
fvm/evm/stdlib/contract.cdc Show resolved Hide resolved
Base automatically changed from ramtin/evm-integrate-into-fvm to master November 14, 2023 20:13
@turbolent turbolent enabled auto-merge November 14, 2023 20:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5d07b31) 56.19% compared to head (beec792) 56.23%.

Files Patch % Lines
fvm/evm/stdlib/contract.go 85.00% 3 Missing and 3 partials ⚠️
fvm/bootstrap.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4889      +/-   ##
==========================================
+ Coverage   56.19%   56.23%   +0.04%     
==========================================
  Files         969      969              
  Lines       90269    90304      +35     
==========================================
+ Hits        50725    50781      +56     
+ Misses      35770    35743      -27     
- Partials     3774     3780       +6     
Flag Coverage Δ
unittests 56.23% <82.22%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent added this pull request to the merge queue Nov 14, 2023
Merged via the queue into master with commit 75fa942 Nov 14, 2023
54 checks passed
@turbolent turbolent deleted the bastian/evm-deposit branch November 14, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants