Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Improve logging and validation in local script exec #4920

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

peterargue
Copy link
Contributor

Closes: #4919
Closes: #4918

This PR includes 3 fixes:

  1. Add validation for address to GetAccount. This was missing from this endpoint, but existed for other GetAccount* endpoints.
  2. Improve error comparison for semantically identical script execution errors
  3. Return InvalidArgument errors from AccessAPI handler when request contained invalid flow.Identifier

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (3704b14) 52.97% compared to head (1de1e25) 57.16%.
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4920      +/-   ##
==========================================
+ Coverage   52.97%   57.16%   +4.18%     
==========================================
  Files         754      785      +31     
  Lines       68131    74061    +5930     
==========================================
+ Hits        36095    42335    +6240     
+ Misses      29316    28512     -804     
- Partials     2720     3214     +494     
Flag Coverage Δ
unittests 57.16% <0.00%> (+4.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
engine/access/rpc/backend/backend_scripts.go 71.18% <0.00%> (ø)

... and 370 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Guitarheroua Guitarheroua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@peterargue peterargue added this pull request to the merge queue Nov 1, 2023
Merged via the queue into master with commit b44227d Nov 1, 2023
35 of 36 checks passed
@peterargue peterargue deleted the petera/4918-fix-getaccount-validation branch November 1, 2023 23:04
peterargue added a commit that referenced this pull request Nov 2, 2023
…ation

[Access] Improve logging and validation in local script exec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants