Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FVM] beyond EVM part 2.1 - adding EVM emulator database #4925

Merged
merged 10 commits into from
Nov 6, 2023

Conversation

ramtinms
Copy link
Contributor

@ramtinms ramtinms commented Nov 2, 2023

The first part of this large PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Attention: 198 lines in your changes are missing coverage. Please review.

Comparison is base (18134c5) 55.77% compared to head (6e37206) 55.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4925      +/-   ##
==========================================
- Coverage   55.77%   55.75%   -0.03%     
==========================================
  Files         953      955       +2     
  Lines       88420    88809     +389     
==========================================
+ Hits        49317    49514     +197     
- Misses      35398    35559     +161     
- Partials     3705     3736      +31     
Flag Coverage Δ
unittests 55.75% <49.61%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
fvm/evm/types/emulator.go 0.00% <ø> (ø)
storage/pebble/registers.go 86.17% <100.00%> (+2.83%) ⬆️
fvm/evm/types/errors.go 11.76% <0.00%> (+11.76%) ⬆️
fvm/evm/emulator/database/storable.go 40.64% <40.64%> (ø)
fvm/evm/emulator/database/database.go 57.52% <57.52%> (ø)

... and 13 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left some comments and suggestions related to atree usage.

fvm/evm/emulator/database/database.go Outdated Show resolved Hide resolved
fvm/evm/emulator/database/database.go Outdated Show resolved Hide resolved
fvm/evm/emulator/database/database.go Outdated Show resolved Hide resolved
fvm/evm/emulator/database/database.go Show resolved Hide resolved
fvm/evm/emulator/database/storable.go Outdated Show resolved Hide resolved
@ramtinms ramtinms requested a review from fxamacker November 2, 2023 21:20
@fxamacker
Copy link
Member

Hey Ramtin, I took another look and left a question (above) about refactor at 164da3d.

Copy link
Member

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D does something like this solve the issue? 0cdbeb8

Yes, thanks! LGTM! 👍

@ramtinms ramtinms added this pull request to the merge queue Nov 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2023
@ramtinms ramtinms added this pull request to the merge queue Nov 6, 2023
Merged via the queue into master with commit 5b91e97 Nov 6, 2023
36 checks passed
@ramtinms ramtinms deleted the ramtin/evm-adding-emulator-database branch November 6, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants