-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FVM] beyond EVM part 2.1 - adding EVM emulator database #4925
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4925 +/- ##
==========================================
- Coverage 55.77% 55.75% -0.03%
==========================================
Files 953 955 +2
Lines 88420 88809 +389
==========================================
+ Hits 49317 49514 +197
- Misses 35398 35559 +161
- Partials 3705 3736 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I left some comments and suggestions related to atree usage.
Hey Ramtin, I took another look and left a question (above) about refactor at 164da3d. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D does something like this solve the issue? 0cdbeb8
Yes, thanks! LGTM! 👍
The first part of this large PR