[Storehouse] Blockend Snapshot #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangchiqing
requested review from
tarakby,
janezpodhostnik,
AlexHentschel and
peterargue
as code owners
zhangchiqing
force-pushed
the
leo/storehouse-blockend-snapshot
branch
from
4556d21 to
3eddf53
Compare
peterargue
reviewed
Nov 16, 2023
zhangchiqing
force-pushed
the
leo/register-store
branch
from
e90aa0d to
f7d8ede
Compare
zhangchiqing
force-pushed
the
leo/storehouse-blockend-snapshot
branch
2 times, most recently
from
b0e3afd to
588de92
Compare
peterargue
reviewed
Nov 16, 2023
zhangchiqing
force-pushed
the
leo/storehouse-blockend-snapshot
branch
from
277608b to
7ac073b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4985 +/- ##
==========================================
+ Coverage 56.25% 56.28% +0.02%
==========================================
Files 974 975 +1
Lines 90802 90840 +38
==========================================
+ Hits 51082 51129 +47
+ Misses 35910 35903 -7
+ Partials 3810 3808 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
approved these changes
Nov 16, 2023
zhangchiqing
force-pushed
the
leo/storehouse-blockend-snapshot
branch
from
03279a6 to
ce7b870
Compare
janezpodhostnik
requested changes
Nov 20, 2023
zhangchiqing
force-pushed
the
leo/storehouse-blockend-snapshot
branch
from
ce7b870 to
7a7009f
Compare
| if value == nil { | ||
| return nil, storage.ErrNotFound | ||
| } | ||
| return value, nil |
There was a problem hiding this comment.
Shouldn't this just return (value, nil) now. If value is nil we want to return nil, right?
janezpodhostnik
approved these changes
Nov 22, 2023
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
zhangchiqing
force-pushed
the
leo/storehouse-blockend-snapshot
branch
from
d1b6468 to
c212feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working towards #4682
BlockEnd Snapshot is used by storehouse as an abstraction for FVM to retrieve register from storage.
BlockEnd means the snapshot is for the state at the end of block.