Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a temporary solution to an issue producing the error:
The way I understand the problem, this is caused because the package
github.com/btcsuite/btcd/chaincfg/chainhash
has two definitions. Whenchainhash
was first created it was part of thebtcd
as a package (this is part of thev0.21.0-beta
btcd module), at a later point it was created as a submodule, but that was not done according to the recommendations https://github.com/zchee/golang-wiki/blob/master/Modules.md#is-it-possible-to-add-a-module-to-a-multi-module-repositoryThis issue was introduced when
go-ethereum
was updated to1.20
from evm and for the first time referenced by fvm, which bubbled the problem to the integration and insecure modules. The next problem becomes in specifying a version ofchainhash
to resolve this issue, but we can not specify the version in go.mod because we don't directly use this package and thus it gets removed by runninggo mod tidy
.This solution adds a reference to
chainhash
so it becomes direct dependency and allows us to specify the concrete version and resolve the conflict.If someone finds a better solution to this I would be very happy to hear what it is but also good luck. This was a day I will never get back 😄
What makes me believe this is an actual issue is also an open issue on go talking about this: golang/go#27899