[Access] Handle script canceled and timeout errors #5036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
requested review from
ramtinms and
janezpodhostnik
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5036 +/- ##
==========================================
+ Coverage 56.20% 56.76% +0.56%
==========================================
Files 973 723 -250
Lines 90624 69158 -21466
==========================================
- Hits 50938 39260 -11678
+ Misses 35883 26844 -9039
+ Partials 3803 3054 -749
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zhangchiqing
approved these changes
Nov 17, 2023
sideninja
reviewed
Nov 20, 2023
sideninja
approved these changes
Nov 20, 2023
janezpodhostnik
approved these changes
Nov 20, 2023
Guitarheroua
approved these changes
Nov 20, 2023
Co-authored-by: Gregor G. <75445744+sideninja@users.noreply.github.com>
peterargue
added a commit
that referenced
this pull request
Nov 20, 2023
…ed-errors [Access] Handle script canceled and timeout errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5030
Explicitly handle FVM errors for context cancelation and timeouts, and return the appropriate errors to the client.