[Access] Update websockets event streaming to return JSON-CDC encoded events #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5048 +/- ##
==========================================
+ Coverage 56.02% 56.29% +0.26%
==========================================
Files 965 975 +10
Lines 89671 90848 +1177
==========================================
+ Hits 50241 51145 +904
- Misses 35678 35894 +216
- Partials 3752 3809 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| wsController.wsErrorHandler(err) | ||
| return | ||
| } | ||
| events[i].Payload = payload |
There was a problem hiding this comment.
This is a event that is only updated with the Payload field, and the rest fields are all empty?
There was a problem hiding this comment.
good catch. I'm not actually sure why tests were passing
There was a problem hiding this comment.
they passed because the handler was overwriting the expected results data. fixed in 5eb72b7
zhangchiqing
approved these changes
Nov 22, 2023
peterargue
added a commit
that referenced
this pull request
Nov 23, 2023
…coding [Access] Update websockets event streaming to return JSON-CDC encoded events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5047
A regression was introduced that cause the events returned from the websockets event streaming endpoint to be CCF encoded. This PR updates the handler to encode to JSON-CDC.