Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master / FLIP 204 #5065

Merged

Conversation

jordanschalm
Copy link
Member

@jordanschalm jordanschalm commented Nov 27, 2023

Merging #5063 did not address the conflicts in the feature -> master PR . Trying again after re-updating both feature and master branches.

ramtinms and others added 30 commits November 14, 2023 15:06
[FVM] beyond EVM part 6.2 - Implement EVM.BridgedAccount.withdraw
…ow/flow-go into ramtin/evm-add-dummy-kitty-contract
[FVM] beyond EVM part 6.3 - Implement EVM.BridgedAccount.deploy
[FVM] beyond EVM part 6.4 - Fix EVM contract tests
[FVM] beyond EVM part 6.5: Improve and test deposit and withdrawal
…all happy-path interfaces are implemented

• extended subscriptions of telemetry consumer to receive missing events
…ts events from `hotstuff.ParticipantConsumer`
peterargue and others added 4 commits November 27, 2023 20:41
…prove-upstream-grpc-failovers

[Observer] Improve upstream gRPC failovers with AN connection pooling
…nflow/flow-go into feature/flip-204-epoch-target-end-time
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 239 lines in your changes are missing coverage. Please review.

Comparison is base (acdd1ec) 56.32% compared to head (2683732) 56.23%.

Files Patch % Lines
network/p2p/test/fixtures.go 0.00% 108 Missing ⚠️
engine/access/apiproxy/access_api_proxy.go 2.50% 78 Missing ⚠️
engine/access/rpc/backend/backend_transactions.go 61.70% 13 Missing and 5 partials ⚠️
engine/common/rpc/convert/execution_data.go 46.42% 15 Missing ⚠️
engine/access/state_stream/backend/backend.go 10.00% 9 Missing ⚠️
engine/access/rpc/connection/manager.go 60.00% 5 Missing and 1 partial ⚠️
utils/unittest/fixtures.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           feature/flip-204-epoch-target-end-time    #5065      +/-   ##
==========================================================================
- Coverage                                   56.32%   56.23%   -0.09%     
==========================================================================
  Files                                         974      976       +2     
  Lines                                       90957    91261     +304     
==========================================================================
+ Hits                                        51229    51319      +90     
- Misses                                      35885    36096     +211     
- Partials                                     3843     3846       +3     
Flag Coverage Δ
unittests 56.23% <30.11%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AndriiDiachuk and others added 3 commits November 28, 2023 17:11
…ock-endpoint-is-missing-system-collection

[Access] Get Block endpoint is missing the system collection
@jordanschalm jordanschalm merged commit 0b64668 into feature/flip-204-epoch-target-end-time Nov 28, 2023
54 checks passed
@jordanschalm jordanschalm deleted the jordan/sync-flip204-master-3 branch November 28, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.