Report proper computation for EVM.encodeABI & EVM.decodeABI methods
#5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideninja
reviewed
Dec 14, 2023
sideninja
reviewed
Dec 14, 2023
sideninja
reviewed
Dec 14, 2023
sideninja
reviewed
Dec 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5146 +/- ##
==========================================
- Coverage 56.43% 49.51% -6.92%
==========================================
Files 981 185 -796
Lines 93068 15605 -77463
==========================================
- Hits 52519 7727 -44792
+ Misses 36661 7355 -29306
+ Partials 3888 523 -3365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sideninja
reviewed
Dec 14, 2023
m-Peter
force-pushed
the
abi-encoding-decoding-computation
branch
from
32e6b6f to
7863c84
Compare
sideninja
approved these changes
Dec 15, 2023
m-Peter
force-pushed
the
abi-encoding-decoding-computation
branch
from
a952d66 to
dc6e35d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
m-Peter
force-pushed
the
abi-encoding-decoding-computation
branch
from
dc6e35d to
b01b1f3
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for: #4937
EVM.encodeABIproactively calculates the length of the[UInt8]resulting array, based on the[AnyStruct]array of Cadence values. Dynamic & static variables are accounted for separately.EVM.decodeABIis the length of the[UInt8]array that is passed in.Decoding a
[UInt8]array that was previously encoded withEVM.encodeABI, takes up the exact same computation as the encoding.