Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Log script exec mismatches as error #5193

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

peterargue
Copy link
Contributor

Update the Access node's script execution comparer to log result and error mismatches using error level. This makes debugging issues easier on production nodes with a lot of traffic.

mismatches are very rare, so this should only generate a handful of new logs per hour.

@peterargue peterargue self-assigned this Jan 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c52c489) 55.92% compared to head (c510f73) 55.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##            v0.32    #5193      +/-   ##
==========================================
- Coverage   55.92%   55.33%   -0.59%     
==========================================
  Files         946      917      -29     
  Lines       89202    85826    -3376     
==========================================
- Hits        49882    47490    -2392     
+ Misses      35603    34784     -819     
+ Partials     3717     3552     -165     
Flag Coverage Δ
unittests 55.33% <100.00%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue merged commit c27cef0 into v0.32 Jan 3, 2024
54 checks passed
@peterargue peterargue deleted the petera/access-script-compare-logging-v0.32 branch January 3, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants