-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Beyond EVM] Updateing StateDB createAccount behaviour to match Geth's latest version #5212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
changed the base branch from
master
to
ramtin/5178-update-geth-version
January 6, 2024 08:35
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5212 +/- ##
==========================================
+ Coverage 54.50% 56.10% +1.59%
==========================================
Files 839 967 +128
Lines 80488 92899 +12411
==========================================
+ Hits 43873 52120 +8247
- Misses 33502 36858 +3356
- Partials 3113 3921 +808
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
changed the title
[WIP] fix evm statedb create func
[Beyond EVM] Updateing StateDB createAccount behaviour to match with Geth's latest version
Jan 6, 2024
ramtinms
changed the title
[Beyond EVM] Updateing StateDB createAccount behaviour to match with Geth's latest version
[Beyond EVM] Updateing StateDB createAccount behaviour to match Geth's latest version
Jan 6, 2024
janezpodhostnik
approved these changes
Jan 8, 2024
ramtinms
requested review from
janezpodhostnik and
sideninja
and removed request for
gregsantos
January 8, 2024 22:23
sideninja
approved these changes
Jan 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the StateDB createAccount behaviour to match Geth's latest version:
When createAccount is called we check if an account exists,
This is the current logic in the Geth code. Note that the EIP about selfDestruct explains the behaviour of the solidity code not necessarily the behaviour of the StateDB. for example a selfDestruction in the code might just check if account exist and call createAccount.