-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Networking] Enhance RPC Inspection with Configurable Thresholds and Granular Metrics Collection #5234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5234 +/- ##
==========================================
+ Coverage 55.57% 56.57% +0.99%
==========================================
Files 995 799 -196
Lines 95297 78246 -17051
==========================================
- Hits 52959 44265 -8694
+ Misses 38361 30610 -7751
+ Partials 3977 3371 -606
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yhassanzadeh13
changed the title
[Networking] Parametrizing duplicate message misbehavior in RPC inpsections
[Networking] Enhance RPC Inspection with Configurable Thresholds and Granular Metrics Collection
Jan 18, 2024
yhassanzadeh13
requested review from
kc1116 and
peterargue
and removed request for
kc1116
January 18, 2024 18:00
…/flow-go into yahya/6927-duplicate-ihave-topics
kc1116
approved these changes
Jan 19, 2024
yhassanzadeh13
force-pushed
the
yahya/6927-duplicate-ihave-topics
branch
from
January 19, 2024 01:58
035cc3a
to
20effab
Compare
peterargue
approved these changes
Jan 22, 2024
yhassanzadeh13
added a commit
that referenced
this pull request
Jan 23, 2024
[Networking] Enhance RPC Inspection with Configurable Thresholds and Granular Metrics Collection
yhassanzadeh13
added a commit
that referenced
this pull request
Jan 23, 2024
* Merge branch 'master' into yahya/relax-invalid-message-deliveyr * Revert "Merge branch 'master' into yahya/relax-invalid-message-deliveyr" This reverts commit a048b2c. * Merge pull request #5234 from onflow/yahya/6927-duplicate-ihave-topics [Networking] Enhance RPC Inspection with Configurable Thresholds and Granular Metrics Collection * Merge pull request #5265 from onflow/yahya/relax-invalid-message-deliveyr [Networking] Relaxes invalid message delivery penalty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issues: