Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] use big.Int for any balance related fields #5236

Merged
merged 11 commits into from
Jan 22, 2024

Conversation

ramtinms
Copy link
Contributor

closes: #5222

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89594b2) 55.44% compared to head (42e05c5) 50.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5236      +/-   ##
==========================================
- Coverage   55.44%   50.50%   -4.95%     
==========================================
  Files         996      196     -800     
  Lines       95786    17433   -78353     
==========================================
- Hits        53108     8804   -44304     
+ Misses      38686     8022   -30664     
+ Partials     3992      607    -3385     
Flag Coverage Δ
unittests 50.50% <ø> (-4.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramtinms ramtinms marked this pull request as ready for review January 15, 2024 22:12
@ramtinms ramtinms requested a review from sideninja January 15, 2024 22:12
@ramtinms ramtinms requested a review from turbolent January 16, 2024 20:12
fvm/evm/types/events.go Outdated Show resolved Hide resolved
@ramtinms ramtinms requested a review from turbolent January 18, 2024 03:31
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have a type alias AttoFlow = *big.Int

@ramtinms ramtinms enabled auto-merge January 19, 2024 07:32
@sideninja
Copy link
Contributor

There's a panic in fvm tests.

@ramtinms ramtinms added this pull request to the merge queue Jan 22, 2024
Merged via the queue into master with commit e3f4d9c Jan 22, 2024
51 checks passed
@ramtinms ramtinms deleted the ramtin/5222-unify-balance-representation branch January 22, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flow EVM] mix use of uint64 and *big.Int for tracking balances
5 participants