Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flow EVM] Include the block hash in evm.BlockExecuted event payload #5245

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

m-Peter
Copy link
Collaborator

@m-Peter m-Peter commented Jan 17, 2024

Currently, the event payload does not include this field:

- height (UInt64): 1
- totalSupply (UInt64): 5000000000000000000
- parentHash (String): "0x0000000000000000000000000000000000000000000000000000000000000000"
- stateRoot (String): "0xe81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421c0"
- receiptRoot (String): "0x48015828c844bff65608bad9fbd1967ea69a2132aaa3223a0d169b4d11cf743e"
- transactionHashes (?): ["0x7b72b5729cafbd2472a7c5b28e2cb9bf6b4de80cc15dae786a0b13aebc54e97e"]
hex: 5b22307837623732623537323963616662643234373261376335623238653263623962663662346465383063633135646165373836613062313361656263353465393765225d

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (3c27e97) 55.99% compared to head (730ac81) 56.29%.

Files Patch % Lines
fvm/evm/types/events.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5245      +/-   ##
==========================================
+ Coverage   55.99%   56.29%   +0.29%     
==========================================
  Files         649      994     +345     
  Lines       63379    95008   +31629     
==========================================
+ Hits        35492    53487   +17995     
- Misses      25321    37544   +12223     
- Partials     2566     3977    +1411     
Flag Coverage Δ
unittests 56.29% <0.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-Peter m-Peter force-pushed the evm-event-with-block-hash branch from 730ac81 to f79b1a2 Compare January 19, 2024 16:29
@m-Peter m-Peter force-pushed the evm-event-with-block-hash branch from f79b1a2 to c4c4240 Compare January 22, 2024 10:21
@m-Peter
Copy link
Collaborator Author

m-Peter commented Jan 22, 2024

cc @sideninja We'll need this for some endpoints of the Flow EVM Gateway.

@sideninja sideninja enabled auto-merge January 22, 2024 14:31
@sideninja sideninja added this pull request to the merge queue Jan 22, 2024
Merged via the queue into onflow:master with commit acea1d4 Jan 22, 2024
51 checks passed
@m-Peter m-Peter deleted the evm-event-with-block-hash branch January 22, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants