[EVM] Selfdesctruct test #5273
Merged
[EVM] Selfdesctruct test #5273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2024 16:13
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5273 +/- ##
==========================================
+ Coverage 55.97% 55.98% +0.01%
==========================================
Files 1017 1017
Lines 98513 98513
==========================================
+ Hits 55139 55156 +17
+ Misses 39163 39151 -12
+ Partials 4211 4206 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ramtinms
reviewed
Jan 26, 2024
ramtinms
approved these changes
Jan 26, 2024
…to gregor/evm/selfdestruct-test
janezpodhostnik
approved these changes
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #5224
This PR adds tests that call selfdestruct function and then make sure the balances are returned, other contract data stays according to the EIP-6780 if not called within the same transaction.