Cadence 1.0 state migrations: Update to new static types migration #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
supun/cadence-migrations
to
feature/stable-cadence
January 26, 2024 01:36
turbolent
force-pushed
the
bastian/update-cadence-migrations
branch
from
934b155 to
9b88742
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5286 +/- ##
==========================================================
- Coverage 55.63% 48.49% -7.14%
==========================================================
Files 1003 169 -834
Lines 96739 14984 -81755
==========================================================
- Hits 53821 7267 -46554
+ Misses 38873 7215 -31658
+ Partials 4045 502 -3543
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
turbolent
commented
Jan 26, 2024
Comment on lines
+158
to
+159
| nil, | ||
| nil, |
There was a problem hiding this comment.
TODO: here we'll probably want to read in a CSV file. Maybe this can be a flag?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards onflow/cadence#3007
Add a utility code to easily define static type migration rules through a CSV file with Cadence syntax