-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add staged contract migration #5300
Add staged contract migration #5300
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #5300 +/- ##
==========================================================
- Coverage 58.45% 55.64% -2.81%
==========================================================
Files 911 998 +87
Lines 86472 96256 +9784
==========================================================
+ Hits 50547 53563 +3016
- Misses 32208 38673 +6465
- Partials 3717 4020 +303
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
01917b2
to
a5b8e04
Compare
…flow/flow-go into supun/staged-contract-migration
443e492
to
9e2f6a0
Compare
9e2f6a0
to
02f8cc5
Compare
…ow-go into supun/staged-contract-migration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
…ow-go into supun/staged-contract-migration
ac81bbc
to
f1c61a9
Compare
f1c61a9
to
e7c7d41
Compare
// Contracts must be migrated first | ||
migrators.CreateAccountBasedMigration( | ||
log, | ||
nWorker, | ||
[]migrators.AccountBasedMigration{ | ||
migrators.NewStagedContractsMigration(migrators.GetStagedContracts), | ||
}, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the proper way to do this: We need to run contract migration for all accounts first, before running other migrations for any account.
|
Sorry, that was my bad, I had changed the format of the error message! |
ah no, that's totally fine! It's a bit fragile/not really a good practice to assert on the error messages anyway. But don't really have a better alternative in this case really. In that test I want to make sure the 'correct' error is on the correct account, path, and the key (which is pretty much the entire error message) |
Closes onflow/cadence#3038