[Flow EVM] update stdlib balance to use UInt instead of UFix64 #5303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t' of github.com:onflow/flow-go into ramtin/4961-evm-update-balance-in-cadence-smart-contract
ramtinms
requested review from
turbolent and
sideninja
and removed request for
janezpodhostnik
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5303 +/- ##
==========================================
- Coverage 55.70% 55.68% -0.03%
==========================================
Files 1002 1002
Lines 96879 96914 +35
==========================================
- Hits 53971 53968 -3
- Misses 38849 38880 +31
- Partials 4059 4066 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Maybe consider using |
ramtinms
changed the title
sideninja
reviewed
Jan 29, 2024
| /// that is used to store account balances inside EVM | ||
| /// similar to the way WEI is used to store ETH divisible to 18 decimal places. | ||
| access(all) | ||
| var attoflow: UInt |
There was a problem hiding this comment.
Just checking if you intentionally name it atttoflow not attoFLOW because it's a new name for metric?
sideninja
approved these changes
Jan 29, 2024
janezpodhostnik
approved these changes
Feb 1, 2024
ramtinms
deleted the
ramtin/4961-evm-update-balance-in-cadence-smart-contract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4961