-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Implement gRPC streaming endpoint SubscribeBlocks #5307
[Access] Implement gRPC streaming endpoint SubscribeBlocks #5307
Conversation
… into UlyanaAndrukhiv/subscribe-blocks
…ndrukhiv/flow-go into UlyanaAndrukhiv/subscribe-blocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly small comments. I think this is pretty much ready to go.
Have you tried this out on localnet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments regarding documentation. I am sure open comment will be addressed so I am approving. Great job, very solid lift.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Great work!
Tagging onflow/developer-grants#242 for Milestone 1 item 9 completion |
…be-blocks [Access] Implement gRPC streaming endpoint SubscribeBlocks
…be-blocks [Access] Implement gRPC streaming endpoint SubscribeBlocks
FLIP: onflow/flips#229
Context
This PR implements
SubscribeBlocks
SubscribeBlockHeaders
SubscribeBlockDigests
endpoints within the Access Node API to facilitate the streaming of blocks at the gRPC level.
This new endpoints have similar functionality of receiving new blocks/headers as
SubscribeEvents
. Additionally, subscribers can define the block status (BlockStatusSealed
orBlockStatusFinalized
) through an argument, receiving only blocks with the specified statuses.As part of this PR:
flow-emulator
have been extended (see [Access] Subscribe endpoints is missing flow-emulator#593)