[Access] Fix event index bounds checking in Access APIs #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5321 +/- ##
==========================================
+ Coverage 55.70% 63.71% +8.00%
==========================================
Files 1002 95 -907
Lines 96879 8609 -88270
==========================================
- Hits 53971 5485 -48486
+ Misses 38849 2812 -36037
+ Partials 4059 312 -3747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
requested review from
zhangchiqing and
sideninja
and removed request for
zhangchiqing
zhangchiqing
approved these changes
Jan 30, 2024
sideninja
approved these changes
Jan 31, 2024
peterargue
added a commit
that referenced
this pull request
Jan 31, 2024
…ecking [Access] Fix event index bounds checking in Access APIs
peterargue
added a commit
that referenced
this pull request
Feb 12, 2024
…ecking [Access] Fix event index bounds checking in Access APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes a bug in the Access API's local event index usage where it would incorrectly return no results instead of an error when a block had not been indexed yet. This was caused by an incorrect assumption about how badger lookups work for group data indexed by block. Currently, the storage scheme does not differentiate between a block with no events and a block that has not been indexed yet. In both cases, an empty set is returned, and it is up to the caller to check if the block should have data.